Skip to content

Conversation

esteve
Copy link
Collaborator

@esteve esteve commented Aug 8, 2025

This adds release-plz for automating releases. For a similar PR for rosidl_runtime_rs, check ros2-rust/rosidl_runtime_rs#14

@esteve esteve requested review from luca-della-vedova, maspe36 and jhdcs and removed request for luca-della-vedova August 8, 2025 16:50
@esteve
Copy link
Collaborator Author

esteve commented Aug 8, 2025

It looks like CI is failing because of colcon/colcon-cargo#63, after adding a toplevel Cargo.toml file for the workspace, rclrs_example_msgs becomes unavailable:

$ colcon info --packages-select rclrs_example_msgs
[0.168s] WARNING:colcon.colcon_core.package_selection:ignoring unknown package 'rclrs_example_msgs' in --packages-select

and this is with the toplevel Cargo.toml file removed:

$ colcon info --packages-select rclrs_example_msgs
path: src/ros2_rust/examples/rclrs_example_msgs
  type: ros.ament_cmake
  name: rclrs_example_msgs
  dependencies:
    build: ament_cmake rosidl_default_generators
    run: rosidl_default_runtime
    test: ament_lint_common
  metadata:
    maintainers: ['Nikolai Morin <[email protected]>']
    version: 0.4.1

@esteve
Copy link
Collaborator Author

esteve commented Aug 8, 2025

Preliminary fix for the colcon-cargo issue in colcon/colcon-cargo#64

Copy link
Collaborator

@maspe36 maspe36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once CI passes

@esteve
Copy link
Collaborator Author

esteve commented Aug 13, 2025

@maspe36 thanks. The ROS APT repo seems to not be fully synced yet, CI is failing to fetch a package that's listed in the repo's Packages file, I've triggered the CI again.

@esteve esteve merged commit b40f96a into ros2-rust:main Aug 13, 2025
9 of 17 checks passed
@esteve esteve deleted the add-release-plz branch August 13, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants