fix: add explicit lifetimes to fix mismatched_lifetime_syntaxes warnings #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Collaborator
Add explicit '_ lifetime annotations to return types where &self implies a lifetime but the return type uses elision to hide it. This addresses the mismatched_lifetime_syntaxes lint enabled by default in recent Rust versions. Fixes 16 warnings across 11 files: - RclPrimitive::handle() trait and all implementations - Various lock() methods returning MutexGuard - NodeState::use_undeclared_parameters() returning Parameters - LogParams::get_logger_name() returning &LoggerName Closes ros2-rust#558
esteve
force-pushed
the
fix/mismatched-lifetime-syntaxes
branch
from
5d2025e to
478a933
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit '_ lifetime annotations to return types where &self implies a lifetime but the return type uses elision to hide it. This addresses the mismatched_lifetime_syntaxes lint enabled by default in recent Rust versions.
Fixes 16 warnings across 11 files:
Closes #558