-
Notifications
You must be signed in to change notification settings - Fork 135
[shape_msgs] New Bounds Msg #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DLu
wants to merge
1
commit into
ros2:rolling
Choose a base branch
from
DLu:bounds
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# Bounds which are useful in several contexts, e.g. to avoid spawning with other object overlap, | ||
# or parking in a spot that is too small. | ||
# Certain goals or points might be valid for a small object, but not suitable for a large one, | ||
# or a differently shaped one. | ||
# Bounds can be also checked to ensure certain scenario conditions are met. | ||
# For entities, these limits are relative to entity's canonical link transform, following ROS rep-103 convention. | ||
|
||
# As bounds are optional in most interfaces, TYPE_EMPTY signifies empty bounds, to be understood as "unbounded". | ||
# Otherwise, the fields are expected to define a valid volume. | ||
# For spawning with a named pose, you should check whether the entity simulation model fits within the bounds | ||
# before calling SpawnEntity, to avoid overlaps and unstable behavior. | ||
|
||
# bounds type | ||
uint8 TYPE_EMPTY = 0 # No bounds. The points vector will be empty. | ||
uint8 TYPE_BOX = 1 # Axis-aligned bounding box, points field should have two values, | ||
# which are upper right and lower left corners of the box. | ||
uint8 TYPE_CONVEX_HULL = 2 # Points define a convex hull (at least 3 non-collinear points). | ||
uint8 TYPE_SPHERE = 3 # A sphere with center and radius. First element of points vector is the center. | ||
# The x field of the second point of the vector is the radius (y and z are ignored). | ||
|
||
|
||
uint8 type | ||
geometry_msgs/Vector3[] points # Points defining the bounded area. Check type field to determine semantics. | ||
# Valid sizes are zero (no bounds), 2 (sphere or box, depending on type field), | ||
# and 3 or more (convex hull). |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What frame is the axis aligned bounding box aligned to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an entirely reasonable question, and looking back, there is no frame specification anywhere. @adamdbrw was there a conversation about this in ros-simulation/simulation_interfaces#1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is specified:
For entities, these limits are relative to entity's canonical link transform, following ROS rep-103 convention.