Removed deprecated actionlib_msgs #280
Conversation
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
|
FYI @tfoote @mjcarroll |
There was a problem hiding this comment.
This was kept around to help with the ROS 1 to ROS 2 migration. In ROS 2 we made actions first class so instead of being actionlib doing the implementation the implementation is in the client libraries. The new messages are in https://index.ros.org/p/action_msgs/
Having these messages enabled at least introspection of ROS 1 actionlib operations. But now that ROS 1 is going EOL there's no requirement for keeping it around.
It would be good to at least ticket the few remaining dependencies on the deprecated package. https://index.ros.org/p/actionlib_msgs/#rolling-deps I suspect that they have old dependencies that can just be cleaned up.
|
@tfoote understood, thanks for the explanation. |
|
I created two PR in the related repositories |
|
Running full CI
|
Removed deprecated actionlib_msgs @see: ros2/common_interfaces#280 Signed-off-by: Jan Vermaete <[email protected]>
Removed deprecated actionlib_msgs @see: ros2/common_interfaces#280 Signed-off-by: Jan Vermaete <[email protected]>
Removed deprecated actionlib_msgs @see: ros2/common_interfaces#280 Signed-off-by: Jan Vermaete <[email protected]>
No description provided.