Get topic name from base class to propagate remaps

[guilyx]

When remapping a topic foo to bar, it appears that Subscriber::getTopic returns the name of the topic as initialized when instantiating the subscriber foo.
In the base class, get topic returns the remapped topic bar, which is in my opinion the correct behavior.

If I were to retrieve the topic I'm subscribing to, I expect to retrieve the remapped name (aka the true name) rather than something that is not used.

Mistaken click

[gbiggs]

@guilyx Could you please add a test that verifies the new behaviour?

[guilyx]

@gbiggs Sure, will take a few days

[CursedRock17]

Hey all, ran into this issue today and this PR would be helpful to prevent it from happening to others. I wrote up two tests on a separate branch to verify it. Would be more beneficial to open a new PR, or add onto this one?

[guilyx]

Thanks for commenting, I forgot this existed (and was never fixed apparently) I could simply merge your branch into mine ?
Let me know!

[CursedRock17]

Sure thing, did you want to rebase your branch first because of the merge conflict? Then I'll shoot the PR over to your branch.

[guilyx]

Yea I need to see, I haven't looked at this in 4Y. As soon as I grab a laptop today I will likely rebase + ping you

[guilyx]

@CursedRock17 all yours. rebased on my fork and added you as a contrib just in case you may not be able to push there. let me know!

[guilyx]

@gbiggs PR should be ready!

[ahcorde]

Pulls: #68
Gist: https://gist.githubusercontent.com/ahcorde/b6e99f11203285c87a3541f4dd03866e/raw/8c1990b377f2ff6947cb0cf25a72ddfb71c3f62d/ros2.repos
BUILD args: --packages-above-and-dependencies message_filters
TEST args: --packages-above message_filters
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17945

• Linux
• Linux-aarch64
• Linux-rhel
• Windows