Skip to content

Commit a29f58e

Browse files
authored
Make sure to mark RingBuffer methods as 'override'. (#2410)
This gets rid of a warning when building under clang. Signed-off-by: Chris Lalancette <[email protected]>
1 parent 676897d commit a29f58e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

rclcpp/include/rclcpp/experimental/buffers/ring_buffer_implementation.hpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
6767
*
6868
* \param request the element to be stored in the ring buffer
6969
*/
70-
void enqueue(BufferT request)
70+
void enqueue(BufferT request) override
7171
{
7272
std::lock_guard<std::mutex> lock(mutex_);
7373

@@ -93,7 +93,7 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
9393
*
9494
* \return the element that is being removed from the ring buffer
9595
*/
96-
BufferT dequeue()
96+
BufferT dequeue() override
9797
{
9898
std::lock_guard<std::mutex> lock(mutex_);
9999

@@ -144,7 +144,7 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
144144
*
145145
* \return `true` if there is data and `false` otherwise
146146
*/
147-
inline bool has_data() const
147+
inline bool has_data() const override
148148
{
149149
std::lock_guard<std::mutex> lock(mutex_);
150150
return has_data_();
@@ -169,13 +169,13 @@ class RingBufferImplementation : public BufferImplementationBase<BufferT>
169169
*
170170
* \return the number of free capacity for new messages
171171
*/
172-
size_t available_capacity() const
172+
size_t available_capacity() const override
173173
{
174174
std::lock_guard<std::mutex> lock(mutex_);
175175
return available_capacity_();
176176
}
177177

178-
void clear()
178+
void clear() override
179179
{
180180
TRACETOOLS_TRACEPOINT(rclcpp_ring_buffer_clear, static_cast<const void *>(this));
181181
}

0 commit comments

Comments
 (0)