Dynamic Subscription (REP-2011 Subset): Stubs for rclcpp #2165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
methylDragon
requested review from
hidmic,
ivanpauno and
wjwwood
as code owners
methylDragon
force-pushed
the
dynamic_subscription_stubs
branch
from
a2ad9cf to
4de3fd1
Compare
methylDragon
force-pushed
the
dynamic_subscription_stubs
branch
from
4de3fd1 to
b1b99ea
Compare
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
dynamic_subscription_stubs
branch
from
b1b99ea to
ee1964f
Compare
Contributor
Author
|
To see what was actually stubbed out, see ee1964f |
Signed-off-by: methylDragon <[email protected]>
Contributor
Author
|
Contributor
Author
|
CI is unstable because of unused parameters (and another unrelated issue on rqt_reconfigure that this PR does not affect), I'll issue a fix soon |
allenh1
reviewed
Apr 12, 2023
Contributor
allenh1
left a comment
allenh1
left a comment
There was a problem hiding this comment.
@methylDragon just some minor comments / questions. Looks good overall.
Signed-off-by: methylDragon <[email protected]>
Contributor
Author
|
clalancette
requested changes
Apr 12, 2023
rclcpp/src/rclcpp/dynamic_typesupport/dynamic_serialization_support.cpp
Outdated
Show resolved
Hide resolved
Contributor
Author
|
clalancette
approved these changes
Apr 12, 2023
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
This looks generally OK to me, assuming CI comes back clean for a run on all packages.
Contributor
Author
Thanks for the review! 🙇 |
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
dynamic_subscription_stubs
branch
from
331b790 to
1243d80
Compare
Contributor
Author
|
🤦 lint errors
|
Contributor
|
@ros-pull-request-builder retest this please |
This was referenced Apr 13, 2023
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/rclcpp
that referenced
this pull request
Jan 12, 2024
* Implement subscription base changes * Add stubbed out classes Signed-off-by: methylDragon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stubbed out version of: #2160
Note: I had to introduce (and stub out) the new dynamic typesupport classes in rclcpp since the virtual methods on SubscriptionBase use them
I added the classes, then stubbed them out in a separate commit so it's clear what's being removed.
Stuff removed are: