Clearer warning message, the old one lacked information and was perhaps misleading #2927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-mitrano-ar
force-pushed
the
rolling-callback-error-improve-warning
branch
from
1726b87 to
80974e1
Compare
…tive Signed-off-by: Peter Mitrano (AR) <[email protected]>
peter-mitrano-ar
force-pushed
the
rolling-callback-error-improve-warning
branch
from
80974e1 to
54a9c82
Compare
fujitatomoya
approved these changes
Aug 8, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
Collaborator
|
Pulls: #2927
|
Contributor
Author
|
I am looking into the failure |
Signed-off-by: Peter Mitrano (AR) <[email protected]>
Signed-off-by: Peter Mitrano (AR) <[email protected]>
Contributor
Author
|
After making the initial fix it seems @fujitatomoya should the test be re-run or ignored somehow? |
fujitatomoya
approved these changes
Aug 8, 2025
Collaborator
|
Contributor
Author
|
Let me know if I can do anything else to help merge! Thank you for being so attentive to this small contribution :) |
jmachowinski
approved these changes
Aug 12, 2025
Collaborator
|
https://github.com/Mergifyio backport kilted jazzy |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
…ps misleading (#2927) * change misleading warning message, making it more correct and informative Signed-off-by: Peter Mitrano (AR) <[email protected]> * Fix compile error. Needed to also build rcl from source. Signed-off-by: Peter Mitrano (AR) <[email protected]> * explicitely initialize pointer as null, to adhere to best practice Signed-off-by: Peter Mitrano (AR) <[email protected]> --------- Signed-off-by: Peter Mitrano (AR) <[email protected]> (cherry picked from commit 3767779)
mergify bot
pushed a commit
that referenced
this pull request
Aug 12, 2025
…ps misleading (#2927) * change misleading warning message, making it more correct and informative Signed-off-by: Peter Mitrano (AR) <[email protected]> * Fix compile error. Needed to also build rcl from source. Signed-off-by: Peter Mitrano (AR) <[email protected]> * explicitely initialize pointer as null, to adhere to best practice Signed-off-by: Peter Mitrano (AR) <[email protected]> --------- Signed-off-by: Peter Mitrano (AR) <[email protected]> (cherry picked from commit 3767779)
jmachowinski
pushed a commit
that referenced
this pull request
Aug 13, 2025
…ps misleading (#2927) (#2931) * change misleading warning message, making it more correct and informative * Fix compile error. Needed to also build rcl from source. * explicitely initialize pointer as null, to adhere to best practice --------- (cherry picked from commit 3767779) Signed-off-by: Peter Mitrano (AR) <[email protected]> Co-authored-by: Peter Mitrano (AR) <[email protected]>
jmachowinski
pushed a commit
that referenced
this pull request
Aug 19, 2025
…ps misleading (#2927) (#2932) * change misleading warning message, making it more correct and informative * Fix compile error. Needed to also build rcl from source. * explicitely initialize pointer as null, to adhere to best practice --------- (cherry picked from commit 3767779) Signed-off-by: Peter Mitrano (AR) <[email protected]> Co-authored-by: Peter Mitrano (AR) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #2924 but for rolling, as @fujitatomoya requested.