Clearer warning message, the old one lacked information and was perhaps misleading (backport #2927) #2931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps misleading (#2927) * change misleading warning message, making it more correct and informative Signed-off-by: Peter Mitrano (AR) <[email protected]> * Fix compile error. Needed to also build rcl from source. Signed-off-by: Peter Mitrano (AR) <[email protected]> * explicitely initialize pointer as null, to adhere to best practice Signed-off-by: Peter Mitrano (AR) <[email protected]> --------- Signed-off-by: Peter Mitrano (AR) <[email protected]> (cherry picked from commit 3767779)
fujitatomoya
approved these changes
Aug 13, 2025
Collaborator
|
Pulls: #2931
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #2924 but for rolling, as @fujitatomoya requested.
This is an automatic backport of pull request #2927 done by Mergify.