Use rmw_test_fixture to isolate ros2cli tests #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott K Logan <[email protected]>
Member
Author
|
PR job failures look real, reverting to draft until they're solved. EDIT: Of course, we'll need a release of |
fujitatomoya
reviewed
Jul 1, 2025
Signed-off-by: Scott K Logan <[email protected]>
cottsay
force-pushed
the
cottsay/rmw-test-isolation
branch
from
31ecfaa to
9c6c5c9
Compare
Member
Author
|
@ros-pull-request-builder retest this EDIT: Manual retry shows only the same two test failures we've had in this package for a while now: https://build.ros2.org/job/Rpr__ros2cli__ubuntu_noble_amd64/218/ |
Member
Author
|
fujitatomoya
approved these changes
Jul 9, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI
Yadunund
approved these changes
Jul 14, 2025
Member
Yadunund
left a comment
Yadunund
left a comment
There was a problem hiding this comment.
LGTM! Excited to see this land!
Member
|
Rerunning CI since it's been a while CI_BRANCH_TO_TEST: cottsay/rmw-test-isolation
|
ahcorde
approved these changes
Jul 15, 2025
Contributor
|
@Mergifyio backport kilted |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2025
Signed-off-by: Scott K Logan <[email protected]> (cherry picked from commit 75e004a)
fujitatomoya
added a commit
that referenced
this pull request
Nov 16, 2025
* Use rmw_test_fixture to isolate ros2cli tests (#1062) Signed-off-by: Scott K Logan <[email protected]> (cherry picked from commit 75e004a) * Fujitatomoya/clearup isolated ros2daemon (#1098) * Enable RMW isolation for ros2doctor.test_report. Signed-off-by: Tomoya Fujita <[email protected]> * ResetEnvironment on shutdown is missing. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process when tests complete. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process for ros2topic. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process for ros2action. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process for ros2doctor. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process for ros2lifecycle and ros2node. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process for ros2param. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> * Missing backport Signed-off-by: Jorge J. Perez <[email protected]> * Fix extra backport Signed-off-by: Jorge J. Perez <[email protected]> * Add missing import Signed-off-by: Jorge J. Perez <[email protected]> --------- Signed-off-by: Scott K Logan <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Jorge J. Perez <[email protected]> Co-authored-by: Scott K Logan <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]> Co-authored-by: Jorge J. Perez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the
rmw_test_isolationsystem for creating a communication sandbox for each test.Fixes # (issue)
Is this user-facing behavior change?
Yes,
ros2cli.helpers.get_rmw_additional_envwill no longer enable multicast for Zenoh.Did you use Generative AI?
No