Fix/Linker path MacOS x86_64 #1483
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviz/rviz_ogre_vendor/CMakeLists.txt Signed-off-by: artcore-c <[email protected]>
Signed-off-by: artcore-c <[email protected]>
Fixed linker path propagation into external Ogre plugins (Codec_Assimp) on MacOS x86_64. Ensured CMake uses -L/opt/local/lib for libminizip resolution. Confirmed MacPorts file tree and symlinks valid. Signed-off-by: artcore-c <[email protected]>
artcore-c
changed the title
|
the Linux build failed on a part I did not change, rviz_default_plugins. so the original CMakeLists.txt will still fail on Linux. there was only a stderr warning on rviz_ogre_vendor, which is pretty normal for this large group of submodules 22:13:26 Failed <<< rviz_default_plugins [14min 7s, exited with code 2] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensured CMake uses -L/opt/local/lib for libminizip resolution.
Confirmed valid with MacPorts minizip, assimp install location and symlinks.
Avoids brute-force or patch-on-patch approaches that can break if upstream changes.
Fixes # (resolves build error
ld: library not found for -lminizipon MacOS x86_64)Fixed linker path propagation into external Ogre plugins (Codec_Assimp).
Added OGRE_CMAKE_ARGS to inject the linker path into the plugin build environment directly.