Replace implementation of RobotLink::createInertia that relies on gz_math with an implementation that uses Eigen#1527
Open
Zyrin wants to merge 1 commit intoros2:rollingfrom
Open
Replace implementation of RobotLink::createInertia that relies on gz_math with an implementation that uses Eigen#1527Zyrin wants to merge 1 commit intoros2:rollingfrom
Zyrin wants to merge 1 commit intoros2:rollingfrom
Conversation
|
@ahcorde How can we test this ? |
Contributor
Author
Contributor
|
Just to understand, so we are removing the heavily tested |
…n implementation that uses Eigen and thus removes the gz_math dependency Signed-off-by: Alexis Tsogias <a.tsogias@cellumation.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the use of gz::math::MassMatrix3d::EquivalentBox in RobotLink::createInertia with an implementation in Eigen similar to what was suggested here: #740 (comment)
This removes the gz_math(_vendor) dependency
This was done because we are building ros2(including rviz2) and gazebo separately and ran into the problem of having two different gz_math(_vendor) libraries/versions.
Is this user-facing behavior change?
No.
Did you use Generative AI?
No.