Open
Conversation
ahcorde
requested changes
Aug 27, 2025
Contributor
|
@mosfet80, what to do with the package.xml, since I currently think it will still try to pull in X11 as a dependency? |
Fix compile on wayland OS
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
Contributor
Author
Fixed |
sloretz
reviewed
Sep 12, 2025
fastcat
reviewed
Dec 11, 2025
Comment on lines
+31
to
+32
| <depend condition="$XDG_SESSION_TYPE == 'x11'">libx11-dev</depend> | ||
| <depend condition="$XDG_SESSION_TYPE == 'wayland'">libwayland-dev</depend> |
There was a problem hiding this comment.
How will this affect the binaries (.debs) provided by ROS? Or any others built by a CI system that has no $XDG_SESSION_TYPE set?
It seems like CI generated binaries, esp. those provided by the ROS project, should be built with compatibility in mind (i.e support both platforms if possible)?
It certainly seems like it would be undesirable for a headless CI system to result in it building with neither X11 nor Wayland support 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix compile on wayland OS
fix #847
tested on opensuse16 with: gnome + qt6 + wayland
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information