Merged
Conversation
Owner
|
No need to apologize. Rather, thanks for the quick response. I’ll take a look tomorrow. |
rsasaki0109
approved these changes
Jul 11, 2025
Owner
|
Merged it now. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves the bug where the
map->odomtransform was being published without a timestamp.I apologize for the oversight in the previous PR.
Changes
src/lidar_localization_component.cpp, within theelseblock forenable_map_odom_tf, I added the following line to set the timestamp for themap_to_odom_stampedmessage:This ensures the transform is correctly timestamped, allowing it to be properly used by other nodes like Navigation2.