[Fixes #65] Transform input point cloud to base_frame to support tilted LiDAR#66
Merged
rsasaki0109 merged 8 commits intorsasaki0109:mainfrom Jul 16, 2025
Merged
[Fixes #65] Transform input point cloud to base_frame to support tilted LiDAR#66rsasaki0109 merged 8 commits intorsasaki0109:mainfrom
rsasaki0109 merged 8 commits intorsasaki0109:mainfrom
Conversation
追加:map->odomのTF変換モードを追加
rsasaki0109
approved these changes
Jul 16, 2025
Owner
|
Thanks for the fix! The implementation looks good. LGTM, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request resolves the issue reported in #65, where using a physically tilted LiDAR resulted in an incorrect pose estimate. The root cause was that the input point cloud was passed to the registration algorithm before being transformed into the robot's base frame.
Implementation Details
This PR introduces a new preprocessing step in the
cloudReceivedfunction:header.frame_idof the incoming PointCloud2 message is different from thebase_frame_idspecified in the parameters.tfbuffer_.lookupTransformto get the transform to thebase_frame_id.pcl::transformPointCloudis used to transform the entire point cloud into thebase_frame_idcoordinate system.This change ensures that localization is always performed consistently relative to the robot's base frame, regardless of the LiDAR's mounting orientation.
Verification
With this fix, I have verified the following: