tests: Add 317-bslib-dashboard #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinycoreci doesn't even test on devel
cpsievert
reviewed
Nov 14, 2023
cpsievert
reviewed
Nov 14, 2023
cpsievert
reviewed
Nov 14, 2023
cpsievert
reviewed
Nov 14, 2023
cpsievert
reviewed
Nov 14, 2023
cpsievert
reviewed
Nov 14, 2023
cpsievert
reviewed
Nov 14, 2023
Co-authored-by: Carson Sievert <[email protected]>
cpsievert
approved these changes
Nov 14, 2023
gadenbuie
commented
Nov 15, 2023
Comment on lines
56
to
59
| p <- chrm$Page$navigate(url, wait_ = FALSE)$ | ||
| then(function(...) chrm$Page$loadEventFired(wait_ = FALSE))$ | ||
| then(function(...) chrm$Runtime$evaluate(shinytest2_js, wait_ = FALSE))$ | ||
| then(function(...) app$wait_for_idle()) |
There was a problem hiding this comment.
Might need to set up the load event as a promise, chaining off that action, rather than chaining from the navigate call. See rstudio/chromote#102
Suggested change
| p <- chrm$Page$navigate(url, wait_ = FALSE)$ | |
| then(function(...) chrm$Page$loadEventFired(wait_ = FALSE))$ | |
| then(function(...) chrm$Runtime$evaluate(shinytest2_js, wait_ = FALSE))$ | |
| then(function(...) app$wait_for_idle()) | |
| p <- chrm$Page$loadEventFired(wait_ = FALSE)$ | |
| then(function(...) chrm$Runtime$evaluate(shinytest2_js, wait_ = FALSE))$ | |
| then(function(...) app$wait_for_idle()) | |
| chrm$Page$navigate(url, wait_ = FALSE) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new test suite for the shiny preset dashboard styles.
This test takes many screenshot but only on MacOS with R-release. I named the screenshot files as helpfully as possible and modified the platform variant to use
mac-release, so that the screenshots are fluid across R versions.