Skip to content

feat: support correcting assert_redirected_to in RSpec/Rails/MinitestAssertions#85

Merged
ydah merged 1 commit intorubocop:masterfrom
nzlaura:feat/assert-redirected-to
Jan 10, 2026
Merged

feat: support correcting assert_redirected_to in RSpec/Rails/MinitestAssertions#85
ydah merged 1 commit intorubocop:masterfrom
nzlaura:feat/assert-redirected-to

Conversation

@nzlaura
Copy link
Contributor

@nzlaura nzlaura commented Jan 9, 2026

This PR adding support for correcting redirect assertions alongside other minitest assertions


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have modified an existing cop's configuration options:

  • Set VersionChanged: "<<next>>" in config/default.yml.

@nzlaura
Copy link
Contributor Author

nzlaura commented Jan 9, 2026

@G-Rath

Copy link
Contributor

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@nzlaura nzlaura marked this pull request as ready for review January 9, 2026 21:07
@nzlaura nzlaura requested a review from a team as a code owner January 9, 2026 21:07
Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydah ydah merged commit 41b6f6f into rubocop:master Jan 10, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants