Fix Grape::Endpoint's inspect method when not called in the context of an API #2492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calls super if env is not defined Add spec
dblock
approved these changes
Sep 1, 2024
lib/grape/endpoint.rb
Outdated
| def inspect | ||
| return super unless env | ||
|
|
||
| "#{self.class} in `#{route.origin}' endpoint" |
There was a problem hiding this comment.
Was this meant to be quoted differently?
Suggested change
| "#{self.class} in `#{route.origin}' endpoint" | |
| "#{self.class} in '#{route.origin}' endpoint" |
There was a problem hiding this comment.
https://bugs.ruby-lang.org/issues/16495
Looks like something cultural
I've added a test that calls |
dblock
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2491