-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix Grape::Endpoint's inspect method when not called in the context of an API #2492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
334aabb
Move inspect method to public
ericproulx dd5154e
Add CHANGELOG.md entry
ericproulx 4f6a48d
Fix rubocop
ericproulx 812175f
Merge branch 'master' into fix_2491
ericproulx e0c1c0a
Fix comments
ericproulx 1067f37
Change backtick for single quote in test
ericproulx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -234,6 +234,15 @@ def equals?(endpoint) | |||||
(options == endpoint.options) && (inheritable_setting.to_hash == endpoint.inheritable_setting.to_hash) | ||||||
end | ||||||
|
||||||
# the purpose of this override is solely for stripping internals when an error occurs while calling | ||||||
ericproulx marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
# an endpoint through an api. See #https://github.com/ruby-grape/grape/issues/2398 | ||||||
ericproulx marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
# Otherwise, it calls super | ||||||
ericproulx marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
def inspect | ||||||
return super unless env | ||||||
|
||||||
"#{self.class} in `#{route.origin}' endpoint" | ||||||
|
"#{self.class} in `#{route.origin}' endpoint" | |
"#{self.class} in '#{route.origin}' endpoint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://bugs.ruby-lang.org/issues/16495
Looks like something cultural
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.