Merged
Conversation
sorah
reviewed
Mar 3, 2026
sorah
approved these changes
Mar 3, 2026
Comment on lines
+460
to
+465
| location /sendai03 { | ||
| include force_https.conf; | ||
| include github_pages.conf; | ||
| proxy_redirect https://sendairb.github.io/sendairk03 $map_request_proto://$http_host/sendai03; | ||
| proxy_pass https://sendairb.github.io; | ||
| } |
There was a problem hiding this comment.
Bug: The location /sendai03 proxies to the wrong upstream path. The content is at /sendairk03, not /sendai03, which will cause 404 errors for users.
Severity: HIGH
Suggested Fix
To fix the 404 error, change the location directive from location /sendai03 to location /sendairk03. This aligns the request path with the actual content path on the GitHub Pages server, as indicated by the proxy_redirect line.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: config/nginx.conf.erb#L460-L465
Potential issue: The nginx configuration for `sendai03` has a path mismatch. The
`location /sendai03` block, combined with `proxy_pass https://sendairb.github.io;`, will
forward requests to `https://sendairb.github.io/sendai03`. However, the `proxy_redirect`
directive in the same block indicates the correct upstream path is
`https://sendairb.github.io/sendairk03`. This inconsistency means any user navigating to
`regional.rubykaigi.org/sendai03` will receive a 404 error because the requested path
does not exist on the GitHub Pages server. This pattern is inconsistent with other
working configurations in the file.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
|
あー、rewriteしないと確かに404になるかも? @thatblue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
仙台Ruby会議03用の転送設定の追加をお願いいたします。
リダイレクト先: https://sendairb.github.io/sendairk03/
Rubyの会 issue: ruby-no-kai/official#566