Skip to content

Add sendai03#151

Merged
sorah merged 2 commits intoruby-no-kai:masterfrom
thatblue:add-sendai03
Mar 3, 2026
Merged

Add sendai03#151
sorah merged 2 commits intoruby-no-kai:masterfrom
thatblue:add-sendai03

Conversation

@thatblue
Copy link
Contributor

@thatblue thatblue commented Mar 3, 2026

仙台Ruby会議03用の転送設定の追加をお願いいたします。

リダイレクト先: https://sendairb.github.io/sendairk03/
Rubyの会 issue: ruby-no-kai/official#566

@sorah sorah enabled auto-merge (squash) March 3, 2026 11:38
@sorah sorah merged commit 853fdf9 into ruby-no-kai:master Mar 3, 2026
2 checks passed
Comment on lines +460 to +465
location /sendai03 {
include force_https.conf;
include github_pages.conf;
proxy_redirect https://sendairb.github.io/sendairk03 $map_request_proto://$http_host/sendai03;
proxy_pass https://sendairb.github.io;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The location /sendai03 proxies to the wrong upstream path. The content is at /sendairk03, not /sendai03, which will cause 404 errors for users.
Severity: HIGH

Suggested Fix

To fix the 404 error, change the location directive from location /sendai03 to location /sendairk03. This aligns the request path with the actual content path on the GitHub Pages server, as indicated by the proxy_redirect line.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: config/nginx.conf.erb#L460-L465

Potential issue: The nginx configuration for `sendai03` has a path mismatch. The
`location /sendai03` block, combined with `proxy_pass https://sendairb.github.io;`, will
forward requests to `https://sendairb.github.io/sendai03`. However, the `proxy_redirect`
directive in the same block indicates the correct upstream path is
`https://sendairb.github.io/sendairk03`. This inconsistency means any user navigating to
`regional.rubykaigi.org/sendai03` will receive a 404 error because the requested path
does not exist on the GitHub Pages server. This pattern is inconsistent with other
working configurations in the file.

Did we get this right? 👍 / 👎 to inform future reviews.

@sorah
Copy link
Member

sorah commented Mar 3, 2026

あー、rewriteしないと確かに404になるかも? @thatblue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants