Skip to content

Add sendai03 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorah merged 2 commits into from
Mar 3, 2026
Merged

Add sendai03 #151

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f83ad74
Add sendai03
thatblue Mar 3, 2026
be86c65
Update config/nginx.conf.erb
sorah Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions config/nginx.conf.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,13 @@ http {
proxy_pass https://hokurikurb.github.io;
}

location /sendai03 {
include force_https.conf;
include github_pages.conf;
proxy_redirect https://sendairb.github.io/sendairk03 $map_request_proto://$http_host/sendai03;
proxy_pass https://sendairb.github.io;
}
Comment on lines +460 to +465
Copy link

@sentry sentry bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The location /sendai03 proxies to the wrong upstream path. The content is at /sendairk03, not /sendai03, which will cause 404 errors for users.
Severity: HIGH

Suggested Fix

To fix the 404 error, change the location directive from location /sendai03 to location /sendairk03. This aligns the request path with the actual content path on the GitHub Pages server, as indicated by the proxy_redirect line.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: config/nginx.conf.erb#L460-L465

Potential issue: The nginx configuration for `sendai03` has a path mismatch. The
`location /sendai03` block, combined with `proxy_pass https://sendairb.github.io;`, will
forward requests to `https://sendairb.github.io/sendai03`. However, the `proxy_redirect`
directive in the same block indicates the correct upstream path is
`https://sendairb.github.io/sendairk03`. This inconsistency means any user navigating to
`regional.rubykaigi.org/sendai03` will receive a 404 error because the requested path
does not exist on the GitHub Pages server. This pattern is inconsistent with other
working configurations in the file.

Did we get this right? 👍 / 👎 to inform future reviews.


# regional.rubykaigi.org
location / {
include force_https.conf;
Expand Down
Loading