Skip to content

🐛 Config.version_defaults should be read only #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 1 commit into from
Jan 9, 2026
+5 −1
Merged

🐛 Config.version_defaults should be read only #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/imap/config/attr_version_defaults.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module AttrVersionDefaults
VERSIONS = ((0.0r..FUTURE_VERSION) % 0.1r).to_a.freeze

# See Config.version_defaults.
singleton_class.attr_accessor :version_defaults
singleton_class.attr_reader :version_defaults

@version_defaults = Hash.new {|h, k|
# NOTE: String responds to both so the order is significant.
Expand Down
4 changes: 4 additions & 0 deletions test/net/imap/test_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ class ConfigTest < Net::IMAP::TestCase
end
assert_same Config.global, config.parent
end
assert_raise(NameError) do Config.method(:version_defaults=) end
assert_raise(NameError) do
Config::AttrVersionDefaults.method(:version_defaults=)
end
end

test "Config[:default] and Config[:current] both hold default config" do
Expand Down