Workaround build task issue in Ruby core CI
#1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is described in ruby/rubygems#8477 The issue fails the workflow whenever RDoc's version is bumped as there will then be a mismatch between the target file name and the version that's actually built. For example: ``` rdoc 6.13.0 built to pkg/rdoc-6.12.0.gem. ``` This commit works around the issue by manually building the gem and installing it locally so the latest installed version will match the version contained in the gemspec file.
Deploying rdoc with
|
| Latest commit: |
5a0710a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8fcdde6d.rdoc-6cd.pages.dev |
| Branch Preview URL: | https://workaround-rubygems-issue-on.rdoc-6cd.pages.dev |
kou
approved these changes
Mar 24, 2025
Comment on lines
58
to
59
| gem build rdoc.gemspec | ||
| gem install rdoc-*.gem |
There was a problem hiding this comment.
I don’t think so…? I don’t usually run gem with bundle as it usually doesn’t need any of the project’s dependencies. Is it a recommended practice?
There was a problem hiding this comment.
Ah, sorry. You're right.
Our .gemspec doesn't use external libraries. So we don't need bundle exec here.
kou
reviewed
Mar 24, 2025
Comment on lines
58
to
59
| gem build rdoc.gemspec | ||
| gem install rdoc-*.gem |
There was a problem hiding this comment.
Ah, sorry. You're right.
Our .gemspec doesn't use external libraries. So we don't need bundle exec here.
Co-authored-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is described in ruby/rubygems#8477
The issue fails the workflow whenever RDoc's version is bumped as there will then be a mismatch between the target file name and the version that's actually built.
For example:
This commit works around the issue by manually building the gem and installing it locally so the latest installed version will match the version contained in the gemspec file.