Skip to content

Workaround build task issue in Ruby core CI #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Workaround build task issue in Ruby core CI #1326

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58f04c4
Workaround `build` task issue in Ruby core CI
st0012 Mar 23, 2025
5a0710a
Update .github/workflows/ruby-core.yml
st0012 Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ruby-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,13 @@ jobs:
with:
path: ruby/rdoc
- name: Build RDoc locally
# The `build` task provided by `require 'bundler/gem_tasks'` seems to have a bug
# as described in https://github.com/rubygems/rubygems/issues/8477
# The manual `gem build` and `gem install` are used to work around this issue.
run: |
bundle install
gem build rdoc.gemspec
gem install rdoc-*.gem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need bundle exec ... here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think so…? I don’t usually run gem with bundle as it usually doesn’t need any of the project’s dependencies. Is it a recommended practice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry. You're right.

Our .gemspec doesn't use external libraries. So we don't need bundle exec here.

bundle exec rake build:local_ruby
working-directory: ruby/rdoc
- name: Generate Documentation with RDoc
Expand Down
Loading