Add cursor-pointer to Nav buttons for better UX #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maebeale
reviewed
Dec 14, 2025
| transition" | ||
| transition cursor-pointer" | ||
| data-action="dropdown#toggle" | ||
| data-dropdown-payload-param='[{"workshop-dropdown":"hidden"}]' |
Collaborator
There was a problem hiding this comment.
i think we should rename the payload to new-dropdown or new-button-dropdown. doesn't have to be this PR.
Collaborator
|
yesss! great catch/upgrade @jmilljr24 !
|
maebeale
approved these changes
Dec 14, 2025
Collaborator
maebeale
left a comment
maebeale
left a comment
There was a problem hiding this comment.
great job noticing we didn't already have this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Hopefully adding a visually indication of the cursor-pointer on mouse over of the nav buttons helps user understand they are clickable.
How did you approach the change?
Anything else to add?
screenrecording-2025-12-05_09-52-38.mp4