Skip to content

Add cursor-pointer to Nav buttons for better UX #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmilljr24 merged 1 commit into from
Dec 14, 2025
Merged

Add cursor-pointer to Nav buttons for better UX #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/views/shared/_navbar_menu.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<button
type="button"
id="facilitate_button"
class="flex items-center gap-1 rounded-md px-3 py-2 text-lg font-medium
class="flex items-center gap-1 rounded-md px-3 py-2 text-lg font-medium cursor-pointer
text-gray-300 hover:bg-white/5 hover:text-white"
data-action="dropdown#toggle"
data-dropdown-payload-param='[{"facilitate_menu":"hidden"}]'>
Expand Down Expand Up @@ -42,7 +42,7 @@
<button
type="button"
id="community_button"
class="flex items-center gap-1 rounded-md px-3 py-2 text-lg font-medium
class="flex items-center gap-1 rounded-md px-3 py-2 text-lg font-medium cursor-pointer
text-gray-300 hover:bg-white/5 hover:text-white"
data-action="dropdown#toggle"
data-dropdown-payload-param='[{"community_menu":"hidden"}]'>
Expand Down Expand Up @@ -87,7 +87,7 @@
<button
type="button"
id="help_button"
class="flex items-center gap-2 rounded-md px-3 py-2 text-lg font-medium
class="flex items-center gap-2 rounded-md px-3 py-2 text-lg font-medium cursor-pointer
text-gray-300 hover:bg-white/5 hover:text-white"
data-action="dropdown#toggle"
data-dropdown-payload-param='[{"help_menu":"hidden"}]'>
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_navbar_new_button.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
flex items-center gap-2 rounded-md bg-white px-4 py-1 mt-1 text-sm font-semibold text-gray-900
shadow-sm border border-gray-200 hover:bg-gray-50 active:bg-gray-100
focus:outline-none focus:ring-2 focus:ring-blue-500 focus:ring-offset-2
transition"
transition cursor-pointer"
data-action="dropdown#toggle"
data-dropdown-payload-param='[{"workshop-dropdown":"hidden"}]'
Copy link
Collaborator

@maebeale maebeale Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should rename the payload to new-dropdown or new-button-dropdown. doesn't have to be this PR.

>
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_navbar_user.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
type="button"
class="
relative flex rounded-full focus-visible:outline-2
focus-visible:outline-offset-2 focus-visible:outline-indigo-500
focus-visible:outline-offset-2 focus-visible:outline-indigo-500 cursor-pointer
"
data-action="dropdown#toggle"
data-dropdown-payload-param='[{"avatar-dropdown":"hidden"}]'
Expand Down