Fix All CASA Admin "Change Password" button#6529
Merged
compwron merged 6 commits intorubyforgood:mainfrom Oct 7, 2025
Merged
Conversation
Signed-off-by: Audrea Cook <audrea@codewitch.dev>
…page Signed-off-by: Audrea Cook <audrea@codewitch.dev>
Signed-off-by: Audrea Cook <audrea@codewitch.dev>
Signed-off-by: Audrea Cook <audrea@codewitch.dev>
AudTheCodeWitch
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
Contributor
Author
|
The docker check is failing. It looks like it might be a flake/failure from an unrelated test. However, I can't figure out how to retry the job (I'm assuming I lack the proper permission). |
compwron
reviewed
Oct 7, 2025
|
|
||
| require "rails_helper" | ||
|
|
||
| RSpec.describe "AllCasaAdmin edit page", type: :system do |
compwron
approved these changes
Oct 7, 2025
Collaborator
|
un/fortunately, part of the point of having both the rspec and docker builds, is to 1. make sure docker keeps working but 2. to be able to tell when one of them is failing on a flake, i.e. both of them are not failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6527
What changed, and why?
The bug fix updates the "Change Password" button and collapse form in
app/views/all_casa_admins/edit.html.erbto use Bootstrap 5 attributes (data-bs-toggle,data-bs-target) instead of Bootstrap 4 (data-toggle,data-target). The parent accordion reference was also removed. Previously, clicking "Change Password" did not expand the password form due to outdated attributes, preventing admins from updating their password. Now, the button correctly toggles the password form, restoring expected functionality and improving user experience.How is this tested?
New test files added:
spec/views/all_casa_admins/edit.html.erb_spec.rb— verifies the correct rendering and behavior of the edit profile view.spec/system/all_casa_admins/edit_spec.rb— covers system-level interactions for editing admin profiles.spec/system/all_casa_admins/password_change_spec.rb— tests the password change workflow, including form expansion and successful/failed updates.Manual testing:
/all_casa_admins/editlocally, confirmed the password form expands and updates work. See Loom demo and screenshots below.Demo
Before:
After:
Feelings gif