web: Improve error when WASM extensions are unsupported but only the module which uses them is available #18838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
force-pushed
the
throw-direct-error-when-reference-types-unsupported
branch
from
c5b9550 to
fec7b36
Compare
danielhjacobs
added
A-web
danielhjacobs
force-pushed
the
throw-direct-error-when-reference-types-unsupported
branch
from
fec7b36 to
fede393
Compare
danielhjacobs
changed the title
torokati44
approved these changes
Jan 8, 2025
torokati44
force-pushed
the
throw-direct-error-when-reference-types-unsupported
branch
from
370f815 to
f1da32d
Compare
Member
|
Even though this will (allegedly) probably not be necessary once we go ahead with #18528, I guess it won't hurt to have it in there either. |
torokati44
force-pushed
the
throw-direct-error-when-reference-types-unsupported
branch
from
f1da32d to
7af4d6b
Compare
Contributor
Author
|
Note: This error should now only appear when using Ruffle on the aforementioned browsers after |
danielhjacobs
changed the title
danielhjacobs
changed the title
Member
|
Yes. Anyway, it should be harmless, and trivial to revert. |
danielhjacobs
deleted the
throw-direct-error-when-reference-types-unsupported
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat the antithesis of #18528. That PR keeps Ruffle running on browsers without reference types support.This shows a better error on browsers without reference-types support when only the with-extensions WASM module is available for use.Merging #18399 will break Ruffle on Safari versions below 15 and Pale Moon. We can keep Ruffle working on those browsers, or we can officially designate them to be unsupported.