fix: raise ValueError when 'model' is passed instead of 'model_name' in BedrockEmbedding#20836
Open
Br1an67 wants to merge 1 commit intorun-llama:mainfrom
Open
fix: raise ValueError when 'model' is passed instead of 'model_name' in BedrockEmbedding#20836Br1an67 wants to merge 1 commit intorun-llama:mainfrom
Br1an67 wants to merge 1 commit intorun-llama:mainfrom
Conversation
dosubot
bot
added
the
size:S
AstraBert
approved these changes
Mar 2, 2026
Member
AstraBert
left a comment
AstraBert
left a comment
There was a problem hiding this comment.
We need to bump the version of the integration before merging
…in BedrockEmbedding Raises a clear ValueError when users pass model= instead of model_name= to BedrockEmbedding. Previously, model= was silently absorbed by **kwargs and ignored, causing the default model (amazon.titan-embed-text-v1) to be used unexpectedly. Bump llama-index-embeddings-bedrock version to 0.7.4.
Br1an67
force-pushed
the
fix/issue-14401-model-name-validation
branch
from
81f7b2e to
10a6571
Compare
Author
|
Thanks for the review! Bumped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raises a clear
ValueErrorwhen users passmodel=instead ofmodel_name=toBedrockEmbedding. Previously,model=was silently absorbed by**kwargsand ignored, causing the default model (amazon.titan-embed-text-v1) to be used unexpectedly.Fixes #14401
New Package?
Version Bump?
llama-index-embeddings-bedrockbumped from0.7.3→0.7.4Type of Change
How Has This Been Tested?
Added
test_model_param_raises_errorwhich verifies thatBedrockEmbedding(model="cohere.embed-multilingual-v3")raisesValueErrorwith a message guiding to usemodel_name.Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods