bytes2hexstring hook #1213
Merged
bytes2hexstring hook #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothtamas28
reviewed
Aug 29, 2025
|
@jberthold, is there a spreadsheet or similar for documenting hook implementations? |
- Added code comment - Renamed hook: bytes2hexstring -> bytes2hex - Improved test case - Use safe length to avoid potential out-of-bounds error
tothtamas28
reviewed
Aug 29, 2025
Co-authored-by: Tamás Tóth <[email protected]>
Robertorosmaninho
approved these changes
Aug 29, 2025
| @@ -9,6 +9,7 @@ expanded_input_file="$(mktemp tmp.in.XXXXXXXXXX)" | |||
| parser_file="$(mktemp tmp.parse.XXXXXXXXXX)" | |||
| temp_inputs=() | |||
|
|
|||
| # shellcheck disable=SC2329 | |||
There was a problem hiding this comment.
Sorry, why is this needed here?
There was a problem hiding this comment.
The shell check CI workflow kept failing, see for example this action: https://github.com/runtimeverification/llvm-backend/actions/runs/17319617915/job/49169763898
If I understand correctly, it's a false positive because the function is used in the following line. So I marked it to skip the check.
It's not related to this PR, I think, but maybe some CI flakiness caused by a shell check update.
There was a problem hiding this comment.
Got it! Thanks for clarifying it!
automergerpr-permission-manager
bot
merged commit fd42f24
into
develop
10 checks passed
automergerpr-permission-manager
bot
deleted the
raoul/bytes2hexstring-dev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new hook implementation for converting byte arrays into hex strings.
This is needed by the kontrol-node to encode memory as JSON strings efficiently.