-
Notifications
You must be signed in to change notification settings - Fork 23
bytes2hexstring hook #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
automergerpr-permission-manager
merged 11 commits into
develop
from
raoul/bytes2hexstring-dev
Aug 29, 2025
Merged
bytes2hexstring hook #1213
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6064005
WIP: bytes2hexstring
RaoulSchaffranek 2c3696c
Run clang-format
RaoulSchaffranek bf40a46
Use pointer arithmetic over array index syntax
RaoulSchaffranek b4ee855
Fix coding style
RaoulSchaffranek 403ee78
Fix coding style
RaoulSchaffranek 058f00d
Ignore shellcheck false positive
RaoulSchaffranek bffdfa4
Move shellcheck directive
RaoulSchaffranek ba49a3d
Address PR feedback
RaoulSchaffranek 97cde58
Run clang-format
RaoulSchaffranek a96f446
Undo changes to bytes2string
RaoulSchaffranek a9729c0
Remove code comment
RaoulSchaffranek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, why is this needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shell check CI workflow kept failing, see for example this action: https://github.com/runtimeverification/llvm-backend/actions/runs/17319617915/job/49169763898
If I understand correctly, it's a false positive because the function is used in the following line. So I marked it to skip the check.
It's not related to this PR, I think, but maybe some CI flakiness caused by a shell check update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Thanks for clarifying it!