Skip to content

Set up nix shell for dev env. Add husky git hooks to run gts check before git commit. Clean up source code files and remove any types.#77

Merged
yiyi-wang-rv merged 6 commits intomasterfrom
dev-env
Jan 5, 2026
Merged

Set up nix shell for dev env. Add husky git hooks to run gts check before git commit. Clean up source code files and remove any types.#77
yiyi-wang-rv merged 6 commits intomasterfrom
dev-env

Conversation

@yiyi-wang-rv
Copy link
Contributor

No description provided.

Copy link
Contributor

@asavienko asavienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +14 to 15
// eslint-disable-next-line @typescript-eslint/no-unused-vars
executable: vscode.DebugAdapterExecutable | undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to work with unused vars like this:

Suggested change
// eslint-disable-next-line @typescript-eslint/no-unused-vars
executable: vscode.DebugAdapterExecutable | undefined
_executable: vscode.DebugAdapterExecutable | undefined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The linter won't let is pass. Probably due to the rule we set. I tried it already 👍

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request sets up a Nix-based development environment, adds Husky pre-commit hooks for code quality checks, and performs extensive TypeScript code cleanup to remove any types and improve type safety across the codebase.

Key Changes:

  • Adds Nix development environment with flake.nix, shell.nix, and .envrc configuration
  • Configures Husky v9 and lint-staged for automatic code linting on git commits
  • Replaces any types with proper TypeScript types (e.g., unknown, Record<string, unknown>)
  • Applies consistent code formatting across all source files
  • Adds GitHub Actions CI workflow for automated testing

Reviewed changes

Copilot reviewed 14 out of 17 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
flake.nix Defines Nix flake for reproducible development environment
flake.lock Lock file for Nix flake dependencies
shell.nix Nix shell configuration with Node.js 20
.envrc Enables automatic Nix shell loading with direnv
.gitignore Adds .direnv to ignored files
package.json Adds Husky and lint-staged dependencies, configures git hooks
package-lock.json Updates dependency lock file with new packages
.husky/pre-commit Pre-commit hook script to run lint-staged
.github/workflows/test.yml CI workflow for linting and compilation checks
src/startDebugging.ts Removes any types, improves formatting and type safety
src/foundry.ts Replaces any with unknown and proper type assertions
src/extension.web.ts Formatting improvements and removes unused assignment
src/extension.ts Formatting improvements and fixes unused variable
src/clone.ts Code formatting and type improvements
src/DebugAdapter.web.ts Removes any types, adds proper TypeScript types
src/DebugAdapter.ts Removes any types, adds eslint disable comments, fixes typo
src/CodelensProvider.ts Adds proper type imports, removes generic any types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yiyi-wang-rv yiyi-wang-rv merged commit 345a829 into master Jan 5, 2026
1 check passed
@yiyi-wang-rv yiyi-wang-rv deleted the dev-env branch January 5, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants