Avoid assumption on unicode casing char length and LNURL override for bitcoin: URIs #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `instructions.to_lowercase().rfind("lnurl")` and then
using the resulting value as a slice index in `instructions`, we
implicitly assume that any unicode lowercasing will not change the
length of any characters. That's probably fine in practice, but it
seems like a weird assumption to make, so instead we swap it for
`to_ascii_lowercase`.
If we have a bitcoin: URI like `bitcoin:thing?lnurl=LNURL...` we really shouldn't use the LNURL override to only resolve the instructions as LNURL. Instead, we fall back to normal URI parsing.
|
Lgtm |
benthecarman
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.