Skip to content

Avoid assumption on unicode casing char length and LNURL override for bitcoin: URIs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Avoid assumption on unicode casing char length and LNURL override for bitcoin: URIs #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a4ad4a
Use `to_ascii_lowercase` when checking for `lnurl` override start
TheBlueMatt Jul 2, 2025
8460fd3
Avoid searching for LNURL override in bitcoin: URIs
TheBlueMatt Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,8 @@ impl PaymentInstructions {
supports_proof_of_payment_callbacks: bool,
) -> Result<PaymentInstructions, ParseError> {
let supports_pops = supports_proof_of_payment_callbacks;
let (uri_proto, _uri_suffix) = split_once(instructions, ':');

if let Ok(hrn) = HumanReadableName::from_encoded(instructions) {
let resolution = hrn_resolver.resolve_hrn(&hrn).await;
let resolution = resolution.map_err(ParseError::HrnResolutionError)?;
Expand Down Expand Up @@ -947,7 +949,11 @@ impl PaymentInstructions {
))
},
}
} else if let Some(idx) = instructions.to_lowercase().rfind("lnurl") {
} else if uri_proto.eq_ignore_ascii_case("bitcoin:") {
// If it looks like a BIP 353 URI, jump straight to parsing it and ignore any LNURL
// overrides.
parse_resolved_instructions(instructions, network, supports_pops, None, None)
} else if let Some(idx) = instructions.to_ascii_lowercase().rfind("lnurl") {
let mut lnurl_str = &instructions[idx..];
// first try to decode as a bech32-encoded lnurl, if that fails, try to drop a
// trailing `&` and decode again, this could a http query param
Expand Down