Improve RecoveryId conversion functions
#800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RecoveryId` is an enum but is typically serialized as an integer. We used to provide a `to_i32` function before rust-bitcoin#743. Add a `to_u8` getter to the `RecoveryId`
|
If this goes in the #765 is redundant and can be closed. |
tcharding
force-pushed
the
06-12-recovery-id-getters
branch
from
8ef905d to
319fa08
Compare
|
In this crate you have to run the nightly formatter to get past CI. |
The `i32` is a hangover from before rust-bitcoin#743, now we have a nice enum and a `from_u8_masked` constructor (along with a `to_u8` getter) lets make the `From<RecoveryId>` impl be on `u8` instead of on `i32`.
tcharding
force-pushed
the
06-12-recovery-id-getters
branch
from
319fa08 to
fed623e
Compare
|
Done, no other changes. |
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
…n functions
fed623ef9803fe28f44e7cd331e25b9149a1154b Implement From on u8 for RecoveryId instead of i32 (Tobin C. Harding)
9b4fa8bdc05ef20f4fadd7f1fb73a51cb41d1854 Add RecoveryId getter (Tobin C. Harding)
Pull request description:
Add the `to_u8` getter discussed in issue #774 and then make the `From` impl be on `u8`.
Close: #774
ACKs for top commit:
apoelstra:
ACK fed623ef9803fe28f44e7cd331e25b9149a1154b; successfully ran local tests
Tree-SHA512: 5a341cbc78d53474a8ffa8fd7fa20796da28e67d226f0298873cd22bfa137d29642b22cabcac1bc8dcd03e6547ae5272990b315dd5808d7e5c775990705cd193
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
…n functions
fed623ef9803fe28f44e7cd331e25b9149a1154b Implement From on u8 for RecoveryId instead of i32 (Tobin C. Harding)
9b4fa8bdc05ef20f4fadd7f1fb73a51cb41d1854 Add RecoveryId getter (Tobin C. Harding)
Pull request description:
Add the `to_u8` getter discussed in issue #774 and then make the `From` impl be on `u8`.
Close: #774
ACKs for top commit:
apoelstra:
ACK fed623ef9803fe28f44e7cd331e25b9149a1154b; successfully ran local tests
Tree-SHA512: 5a341cbc78d53474a8ffa8fd7fa20796da28e67d226f0298873cd22bfa137d29642b22cabcac1bc8dcd03e6547ae5272990b315dd5808d7e5c775990705cd193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
to_u8getter discussed in issue #774 and then make theFromimpl be onu8.Close: #774