CI: Re-enable WASM job #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#818 was merged -- you can rebase and undraft this. Looks like it worked, nice! |
Un-comment the wasm job now that WASM builds again - maybe.
tcharding
force-pushed
the
07-04-ci-enablem-wasm
branch
from
1e4c21e to
1800e73
Compare
|
That was easy. Props to @andunieee for bringing the issue to our attention. |
|
Fucking Github. This did not "pass CI". Github silently disabled all of our checks because the spacing in this PR was wrong. #840. |
|
ouch |
apoelstra
added a commit
that referenced
this pull request
Aug 30, 2025
471cd63 ci: delete broken WASM job (Andrew Poelstra) 0d0263e secp-sys: update raw pointer deref syntax in fuzz version of the crate (Andrew Poelstra) d477198 ci: remove now-removed 'hashes' feature from tests (Andrew Poelstra) Pull request description: The incorrectly-indented wasm test from #819 is causing Github to silently disable all of our checks. If you click through to the "Actions" tab of this repo you can see it failing (with a "syntax error on line 1" nonsense error). For example https://github.com/apoelstra/rust-secp256k1/actions/runs/17178718613/workflow Delete the test, and also fix everything else that broke in the meantime. ACKs for top commit: tcharding: ACK 471cd63 Tree-SHA512: b52f86a203cb08f66ecbe2afc6e85d973193373da9d5a8bc7e10ca4f9b0991a69cf30e851b439ad6c463b468d10a35c87540fabc6b9ed877fadd82df74221fe8
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
1800e7347212e1a532df83a7c15d4c224aa1d310 CI: Re-enable WASM job (Tobin C. Harding)
Pull request description:
On top of #818, this was quicker than writing an issue. Maybe it will just work.
ACKs for top commit:
apoelstra:
ACK 1800e7347212e1a532df83a7c15d4c224aa1d310; successfully ran local tests
Tree-SHA512: 29787ca03f5f3354d635d5cb24a033299385119fdc40d98dbe063aefd04319147c4b72ced5a5b5a411b513138b91cb55e4d4627bc17e1f7c202f3f485a0952e0
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
1800e7347212e1a532df83a7c15d4c224aa1d310 CI: Re-enable WASM job (Tobin C. Harding)
Pull request description:
On top of #818, this was quicker than writing an issue. Maybe it will just work.
ACKs for top commit:
apoelstra:
ACK 1800e7347212e1a532df83a7c15d4c224aa1d310; successfully ran local tests
Tree-SHA512: 29787ca03f5f3354d635d5cb24a033299385119fdc40d98dbe063aefd04319147c4b72ced5a5b5a411b513138b91cb55e4d4627bc17e1f7c202f3f485a0952e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #818, this was quicker than writing an issue. Maybe it will just work.