ci: delete broken wasm job #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
apoelstra
changed the title
Rust 1.88.0 introduced a warning, and 1.89.0 made it an error, to dereference a raw pointer in a way where it is implicitly turned into a reference. This is probably a good lint but breaking compilation like this is bullshit. There are many instances of this in our fuzz code (none in the real code). We just need to change the implicit & and &muts to explicit ones. We will need to backport some change if we want our CI to keep working on old versions. Probably just whitelisting the lint for old versions of the library is fine.
Incorrect indentation causes Github to report "syntax error on line 1" and silently disable all of the checks in this library. For example, see https://github.com/apoelstra/rust-secp256k1/actions/runs/17178718613/workflow After fixing the indentation, the test doesn't work, obviously, because it's a wasm test.
apoelstra
changed the title
tcharding
approved these changes
Aug 29, 2025
|
So is WASM no longer supported? |
|
WASM has only ever been "supported" in the sense that I accept harmless PRs from people that claim to be necessary for wasm support (e.g. things related to C headers). Historically I've been willing to accept CI PRs, and we've even gone months before with a passing "WASM" job (until the wasm people broke their tooling, which they do constantly), though I'll be more suspicious of those in the future. But I personally have never successfully compiled this crate to wasm. The last time I seriously tried was over two years ago, when I filed a bug about basic command-line flags not working which has been ignored ever since. |
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
471cd63ee509489b997e6dfefc18f927c3da986e ci: delete broken WASM job (Andrew Poelstra) 0d0263e3fdf25ed57b8ee82105b1a2ccbd56cd42 secp-sys: update raw pointer deref syntax in fuzz version of the crate (Andrew Poelstra) d47719858d53ada986a5f44fe235cc107e7eb81f ci: remove now-removed 'hashes' feature from tests (Andrew Poelstra) Pull request description: The incorrectly-indented wasm test from #819 is causing Github to silently disable all of our checks. If you click through to the "Actions" tab of this repo you can see it failing (with a "syntax error on line 1" nonsense error). For example https://github.com/apoelstra/rust-secp256k1/actions/runs/17178718613/workflow Delete the test, and also fix everything else that broke in the meantime. ACKs for top commit: tcharding: ACK 471cd63ee509489b997e6dfefc18f927c3da986e Tree-SHA512: b52f86a203cb08f66ecbe2afc6e85d973193373da9d5a8bc7e10ca4f9b0991a69cf30e851b439ad6c463b468d10a35c87540fabc6b9ed877fadd82df74221fe8
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
471cd63ee509489b997e6dfefc18f927c3da986e ci: delete broken WASM job (Andrew Poelstra) 0d0263e3fdf25ed57b8ee82105b1a2ccbd56cd42 secp-sys: update raw pointer deref syntax in fuzz version of the crate (Andrew Poelstra) d47719858d53ada986a5f44fe235cc107e7eb81f ci: remove now-removed 'hashes' feature from tests (Andrew Poelstra) Pull request description: The incorrectly-indented wasm test from #819 is causing Github to silently disable all of our checks. If you click through to the "Actions" tab of this repo you can see it failing (with a "syntax error on line 1" nonsense error). For example https://github.com/apoelstra/rust-secp256k1/actions/runs/17178718613/workflow Delete the test, and also fix everything else that broke in the meantime. ACKs for top commit: tcharding: ACK 471cd63ee509489b997e6dfefc18f927c3da986e Tree-SHA512: b52f86a203cb08f66ecbe2afc6e85d973193373da9d5a8bc7e10ca4f9b0991a69cf30e851b439ad6c463b468d10a35c87540fabc6b9ed877fadd82df74221fe8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrectly-indented wasm test from #819 is causing Github to silently disable all of our checks. If you click through to the "Actions" tab of this repo you can see it failing (with a "syntax error on line 1" nonsense error). For example https://github.com/apoelstra/rust-secp256k1/actions/runs/17178718613/workflow
Delete the test, and also fix everything else that broke in the meantime.