libm: implement accelerated computation of (x << e) % y
#1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Aug 13, 2025
Comment on lines
+301
to
+304
| + core::ops::Add<Output = Self> | ||
| + core::ops::Sub<Output = Self> | ||
| + core::ops::Shl<u32, Output = Self> | ||
| + core::ops::Shr<u32, Output = Self> |
There was a problem hiding this comment.
core::ops -> ops since it's already in scope
There was a problem hiding this comment.
I think this commit should be able to allow the #[allow(dead_code)] on NarrowingDiv
Comment on lines
+1
to
+2
| use crate::support::int_traits::NarrowingDiv; | ||
| use crate::support::{DInt, HInt, Int}; |
There was a problem hiding this comment.
Could you add a module-level doc comment with some of the common names used here? E.g. R, RR (if that's not R*R) r, m, q, xq. I'm unfortunately a bit lost :) (but I don't need to understand it in detail)
There was a problem hiding this comment.
If you've authored this, add /* SPDX-License-Identifier: MIT OR Apache-2.0 */ as well (or only MIT if it's derived, as appropriate)
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod test { |
There was a problem hiding this comment.
Could this spot check another integer size as well? Just using constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1011, both were split from #1002
The computation is implemented in
linear_mul_reduction.