handle other PrepareErrors#788
Conversation
3b3876f to
f67fab2
Compare
8119190 to
e625c1b
Compare
|
ping: This is waiting on review. |
|
ping, this is still waiting on review @Mark-Simulacrum and @emilyalbini you two have reviewed PRs here in the past. SummaryThis now handles not explicitly handled PrepareError. Edit: Currently these get misclassified as error Note: since this PR has been last updated rustwide has had more releases, maybe the rustwide dependency should be bumped further? |
|
Happy to bump rustwide further and then merge this, it seems fine to me. |
without this on windows cargo check fails due to aws-lc-sys failing to find cmake
dc5a5c0 to
ed6c0c6
Compare
|
As of rust-lang/rustwide#103 rustwide 0.20 can now also return other PrepareErros than those already handled.
This sorts those into either prepare-fail or broken depending on whether we can identify a known underlying reason and whether that reason is spurious or not.
Spurious and unknown failures are categorized as prepare-fail and known non-spurious errors are classified as broken.
Note rustwide PR rust-lang/rustwide#98 is in progress and aims to reduce the cases that will be falsely classified as prepare-fail instead of broken.rust-lang/rustwide#98 has been merged and the rustwide dependency has been bumped to a version including it.