Skip to content

handle other PrepareErrors#788

Merged
Mark-Simulacrum merged 7 commits intorust-lang:masterfrom
Skgland:handle_other_prepare_errors
Mar 19, 2026
Merged

handle other PrepareErrors#788
Mark-Simulacrum merged 7 commits intorust-lang:masterfrom
Skgland:handle_other_prepare_errors

Conversation

@Skgland
Copy link
Contributor

@Skgland Skgland commented Jul 22, 2025

As of rust-lang/rustwide#103 rustwide 0.20 can now also return other PrepareErros than those already handled.
This sorts those into either prepare-fail or broken depending on whether we can identify a known underlying reason and whether that reason is spurious or not.
Spurious and unknown failures are categorized as prepare-fail and known non-spurious errors are classified as broken.

Note rustwide PR rust-lang/rustwide#98 is in progress and aims to reduce the cases that will be falsely classified as prepare-fail instead of broken.

rust-lang/rustwide#98 has been merged and the rustwide dependency has been bumped to a version including it.

@Skgland Skgland force-pushed the handle_other_prepare_errors branch from 3b3876f to f67fab2 Compare July 22, 2025 21:24
@Skgland Skgland force-pushed the handle_other_prepare_errors branch 2 times, most recently from 8119190 to e625c1b Compare August 22, 2025 19:11
@Skgland Skgland marked this pull request as ready for review August 22, 2025 19:30
@Skgland Skgland mentioned this pull request Dec 12, 2025
@Skgland
Copy link
Contributor Author

Skgland commented Jan 25, 2026

ping: This is waiting on review.

@Skgland
Copy link
Contributor Author

Skgland commented Feb 14, 2026

ping, this is still waiting on review

@Mark-Simulacrum and @emilyalbini you two have reviewed PRs here in the past.

Summary

This now handles not explicitly handled PrepareError.
Tries to find the failure reason and then sorts spurious or unknown failure reason into
PrepareFail so that it lands on the retry-regressed-list.txt.
Known non-spurious failures are classified as BrokenCrate indicating a problem with the crate/repository.

Edit: Currently these get misclassified as error

Note: since this PR has been last updated rustwide has had more releases, maybe the rustwide dependency should be bumped further?

@Mark-Simulacrum
Copy link
Member

Happy to bump rustwide further and then merge this, it seems fine to me.

@Skgland Skgland force-pushed the handle_other_prepare_errors branch from dc5a5c0 to ed6c0c6 Compare March 9, 2026 22:20
@Skgland
Copy link
Contributor Author

Skgland commented Mar 10, 2026

Happy to bump rustwide further and then merge this, it seems fine to me.

  • ran cargo update in d490b35 to fix compilation on windows
  • updated rustwide to latest version
  • updated deps pulling in toml@0.8 to reduce duplicate deps
  • updated test expectations as the error messages of the toml crate changed and apparently also the error code returned by rust for one of the minicrater crates

@Mark-Simulacrum Mark-Simulacrum added this pull request to the merge queue Mar 19, 2026
Merged via the queue into rust-lang:master with commit dd19a64 Mar 19, 2026
3 checks passed
@Skgland Skgland deleted the handle_other_prepare_errors branch March 19, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants