fix endless loop when generating fastly invalidations #3033
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
| )) | ||
| let keys = SurrogateKeys::from_iter_until_full(it.take(MAX_SURROGATE_KEYS_IN_BATCH_PURGE)); | ||
|
|
||
| if keys.key_count() > 0 { |
Member
Author
There was a problem hiding this comment.
yes, it is also part of that,
it was a quickfix for the case that the review would be fast enough :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we want a hotfix.
I'm also working on dropping the fastly api lib for direct reqwests.
we're getting an error, I think when shutting down the server:
https://rust-lang.sentry.io/issues/7060459082/?query=is%3Aunresolved&referrer=issue-stream
My guess is that the fastly client tries to do some background work?
So in parallel I'm working on dropping the library, which won't take much longer.
this PR is not needed when we review & merge #3034