Skip to content

fix endless loop when generating fastly invalidations #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+7 −3
Closed

fix endless loop when generating fastly invalidations #3033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/cdn/fastly.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,13 @@ where
// SurrogateKeys::from_iter::until_full only consumes as many elements as will fit into
// the header.
// The rest is up to the next `batching` iteration.
Some(SurrogateKeys::from_iter_until_full(
it.take(MAX_SURROGATE_KEYS_IN_BATCH_PURGE),
))
let keys = SurrogateKeys::from_iter_until_full(it.take(MAX_SURROGATE_KEYS_IN_BATCH_PURGE));

if keys.key_count() > 0 {
Copy link
Member

@GuillaumeGomez GuillaumeGomez Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait isn't part of #3034?

Copy link
Member Author

@syphar syphar Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is also part of that,

it was a quickfix for the case that the review would be fast enough :)

Copy link
Member Author

@syphar syphar Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or it was a test ;)

Some(keys)
} else {
None
}
}) {
for sid in config
.fastly_service_sid_web
Expand Down
Loading