libc-test: port windows to use ctest-next #4600
Conversation
mbyx
force-pushed
the
libc-test-windows-port
branch
from
d4e8842 to
5771cf0
Compare
mbyx
force-pushed
the
libc-test-windows-port
branch
4 times, most recently
from
809ef9f to
0306748
Compare
|
|
mbyx
force-pushed
the
libc-test-windows-port
branch
3 times, most recently
from
1692d40 to
9428748
Compare
mbyx
force-pushed
the
libc-test-windows-port
branch
8 times, most recently
from
ab9e478 to
3dbb7a5
Compare
mbyx
force-pushed
the
libc-test-windows-port
branch
3 times, most recently
from
89bbc29 to
3dcc655
Compare
mbyx
force-pushed
the
libc-test-windows-port
branch
from
3dcc655 to
8f770d3
Compare
| _ => None, | ||
| } | ||
| }); | ||
| cfg.rename_type(move |ty| { |
There was a problem hiding this comment.
In ctest we should rename this function rename_alias or rename_type_alias, I was thinking it handled all types for a bit
There was a problem hiding this comment.
It handles all non struct and union types, we don't actually have a rename_alias method (although we can add it), since ctest doesn't use it. But rename_alias would be a different method (rename_type uses MapInput::Type, rename_alias would use MapInput::Alias).
There was a problem hiding this comment.
Is rename_type just a catch-all for renaming anything? If so, tbh I think we should remove it: it's better to be more specific about what you expect to rename
Description
This PR adds support for testing the windows platform using
ctest-nextas well as the originalctest. A minor bug was also fixed along the way, where we have some public primitive types that aren't available in C (this can be fixed with skips instead as well).Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI