Skip to content

Conversation

@ljgermain
Copy link
Contributor

fixes #13445
changelog: [invalid_null_ptr_usage]: fix false positives for std::ptr::slice_from_raw_parts functions

@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Centri3 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 24, 2024
Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Centri3
Copy link
Member

Centri3 commented Sep 24, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2024

📌 Commit 31bbe2c has been approved by Centri3

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 24, 2024

⌛ Testing commit 31bbe2c with merge cbe294c...

@bors
Copy link
Contributor

bors commented Sep 24, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Centri3
Pushing cbe294c to master...

@bors bors merged commit cbe294c into rust-lang:master Sep 24, 2024
8 checks passed
bors added a commit that referenced this pull request Oct 14, 2024
Use correct std/core prefix in lint output

changelog: none

I was waiting for #13452 to be merged before sending this one. `std` is used instead of `core` when appropriate in messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive for invalid null pointer usage lint when creating raw slice pointer

4 participants