Skip to content

New lint: borrow_mutable_copy #13984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New lint: borrow_mutable_copy #13984

wants to merge 1 commit into from

Conversation

samueltardieu
Copy link
Member

@samueltardieu samueltardieu commented Jan 11, 2025 •
edited
Loading

This detects when the result of a block, with a Copy type, is borrowed mutably. The user might not be aware that using a block will borrow a copy instead of the value expression itself.

changelog: [borrow_mutable_copy]: new lint

Close #13967

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 11, 2025
@samueltardieu samueltardieu force-pushed the push-kpvspntvlrtr branch 2 times, most recently from a881f75 to 1ac5de7 Compare January 12, 2025 08:37
@samueltardieu
Copy link
Member Author

Rebased

@samueltardieu
Copy link
Member Author

Rebased

@samueltardieu
Copy link
Member Author

r? @Clippy

@rustbot rustbot assigned flip1995 and unassigned blyxyas Jan 31, 2025
@samueltardieu
Copy link
Member Author

Rebased

@samueltardieu
Copy link
Member Author

Rebased

flip1995
flip1995 reviewed Feb 10, 2025
View reviewed changes
@samueltardieu
Copy link
Member Author

@flip1995 Anything else needs to be done?

@flip1995
Copy link
Member

I guess the FCP on Zulip. Feel free to start that :)

@samueltardieu
Copy link
Member Author

FCP opened on https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/FCP.3A.20copy_then_borrow_mut

@samueltardieu samueltardieu force-pushed the push-kpvspntvlrtr branch 2 times, most recently from 410fe93 to b0e27cc Compare February 28, 2025 14:15
Alexendoo
Alexendoo reviewed Mar 22, 2025
View reviewed changes
@samueltardieu samueltardieu force-pushed the push-kpvspntvlrtr branch 4 times, most recently from eac9c71 to 5309578 Compare March 25, 2025 21:58
@samueltardieu samueltardieu changed the title New lint: copy_then_borrow_mut New lint: borrow_mutable_copy May 21, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 21, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@samueltardieu
Copy link
Member Author

samueltardieu commented May 21, 2025 •
edited
Loading

I've put it back into suspicious, with MaybeIncorrect applicability.

@samueltardieu
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels May 21, 2025
@rustbot

This comment has been minimized.

Sign in to view
@samueltardieu
Copy link
Member Author

Rebased

@rustbot

This comment has been minimized.

Sign in to view
@samueltardieu
Copy link
Member Author

Rebased

@rustbot

This comment has been minimized.

Sign in to view
@samueltardieu
Copy link
Member Author

Should I close this or will it be merged?

@samueltardieu
Copy link
Member Author

Updated Rust version to 1.90.0.

@rustbot

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@Jarcho
Copy link
Contributor

Jarcho commented Sep 17, 2025

r? clippy

@rustbot rustbot assigned llogiq and unassigned flip1995 Sep 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2025

☔ The latest upstream changes (possibly #15731) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centri3 Centri3 Centri3 left review comments

@flip1995 flip1995 Awaiting requested review from flip1995

@Alexendoo Alexendoo Awaiting requested review from Alexendoo

Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reborrow or copy-then-borrow
8 participants
@samueltardieu @rustbot @flip1995 @Jarcho @Alexendoo @Centri3 @llogiq @blyxyas