Skip to content

Fix large_stack_frames FP on compiler generated targets #15101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix large_stack_frames FP on compiler generated targets #15101

wants to merge 1 commit into from
+262 −44

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Jun 22, 2025 •
edited by rustbot
Loading

Closes #15099

The compiler will generate a special main function for the tests, which caused this FP.

changelog: [large_stack_frames] fix FP on compiler generated targets

@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 22, 2025
samueltardieu
samueltardieu requested changes Jun 22, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 22, 2025
@profetia profetia requested a review from samueltardieu June 22, 2025 08:37
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jun 22, 2025
samueltardieu

This comment was marked as duplicate.

Sign in to view

samueltardieu
samueltardieu previously requested changes Jun 22, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 22, 2025
@y21 y21 mentioned this pull request Jun 22, 2025
Open
@LebedevRI
Copy link

@profetia @samueltardieu @y21 thank you!

@rustbot rustbot assigned y21 and unassigned samueltardieu Jun 26, 2025
@samueltardieu samueltardieu dismissed their stale review June 26, 2025 08:50

Reassigned

y21
y21 reviewed Jun 26, 2025
View reviewed changes
@profetia profetia force-pushed the issue15099 branch 2 times, most recently from ce992be to 4ddb621 Compare July 13, 2025 09:57
@profetia
Copy link
Contributor Author

@y21 I've updated this PR based on the above discussions:

  • A new lint_inside_tests option is added to determine whether to lint inside test modules.
  • A new lint_macro_generated_functions option is added to determine whehter to lint macro generated functions. When giving such lint, it will happen on the macro call span that generated the function, and tell the user about that.

@profetia profetia requested a review from y21 July 13, 2025 10:01
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jul 13, 2025
@github-actions
Copy link

github-actions bot commented Jul 13, 2025 •
edited
Loading

Lintcheck changes for 3881e16

Lint Added Removed Changed
clippy::large_stack_frames 15 15 0

This comment will be updated if you push new changes

y21
y21 reviewed Jul 13, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure about the newly added configuration options, mostly because I can't see a use case for them and it complicates clippy. I'd have much more preferred the initial version of the PR which was much simpler.

@profetia profetia force-pushed the issue15099 branch 3 times, most recently from 4d142c1 to 5e69dd9 Compare July 13, 2025 15:11
@profetia
Copy link
Contributor Author

@y21 After second thought, I think you are right. I updated so that:

  • lint_inside_tests is renamed.
  • lint_macro_generated_functions is renamed.
  • When linting on macro generated function, the function name will be showed in the message.
  • If the function is not from derive, the function declearation and largest part will be noted, even when it is from proc-macro.

@profetia profetia requested a review from y21 July 13, 2025 15:13
@profetia profetia force-pushed the issue15099 branch 2 times, most recently from e78dbc0 to 6a65528 Compare July 20, 2025 04:12
@profetia
Copy link
Contributor Author

Any feedback? @y21

@profetia
Copy link
Contributor Author

Any feedback? @y21

@profetia profetia mentioned this pull request Aug 15, 2025
Merged
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned flip1995 and unassigned y21 Aug 29, 2025
@profetia
Copy link
Contributor Author

@flip1995 Updated. Thank you!

@profetia profetia requested a review from flip1995 August 31, 2025 16:08
@profetia
Copy link
Contributor Author

@flip1995 Any feedback?

@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned llogiq and unassigned flip1995 Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu left review comments

@y21 y21 Awaiting requested review from y21

@flip1995 flip1995 Awaiting requested review from flip1995

Assignees

@llogiq llogiq

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

large_stack_frames: unsilenceable diagnostic about compiler-generated functions

7 participants

@profetia @rustbot @LebedevRI @samueltardieu @flip1995 @y21 @llogiq