-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Run main rust-analyzer tests in rust-lang/rust CI #147372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bors try |
[DO NOT MERGE] Run main rust-analyzer tests try-job: aarch64-gnu try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: x86_64-msvc-1 try-job: aarch64-msvc-1
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
9f7d76f to
43d7f3e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
43d7f3e to
bcc2aae
Compare
|
Huh. |
[DO NOT MERGE] Run main rust-analyzer tests try-job: aarch64-gnu try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: x86_64-msvc-1 try-job: aarch64-msvc-1
This comment has been minimized.
This comment has been minimized.
|
I'd consider this a win? |
This comment was marked as resolved.
This comment was marked as resolved.
… r=Kobzol bootstrap: don't build book redirect pages during dry-run/test Currently, `./x test bootstrap` does not automatically transitively checkout submodules needed to pass all involved test steps. Apparently one place where bootstrap's self-test can choke on locally is trying to build book redirect pages without the book submodules checked out. This change is orthogonal to making bootstrap checking out required submodules for self-tests, and IMO is beneficial regardless since IMO we should not be building these redirect pages during test/dry-run _anyway_. This was blocking me trying to rebless bootstrap self-tests for rust-lang#147372. cf. [#t-infra/bootstrap > Bootstrap self-tests @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Bootstrap.20self-tests/near/543157194). r? `@Kobzol` (or bootstrap)
Rollup merge of #147374 - jieyouxu:bootstrap-redirect-pages, r=Kobzol bootstrap: don't build book redirect pages during dry-run/test Currently, `./x test bootstrap` does not automatically transitively checkout submodules needed to pass all involved test steps. Apparently one place where bootstrap's self-test can choke on locally is trying to build book redirect pages without the book submodules checked out. This change is orthogonal to making bootstrap checking out required submodules for self-tests, and IMO is beneficial regardless since IMO we should not be building these redirect pages during test/dry-run _anyway_. This was blocking me trying to rebless bootstrap self-tests for #147372. cf. [#t-infra/bootstrap > Bootstrap self-tests @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Bootstrap.20self-tests/near/543157194). r? `@Kobzol` (or bootstrap)
c72221d to
0af3c68
Compare
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Run main rust-analyzer tests in rust-lang/rust CI try-job: aarch64-gnu try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: x86_64-msvc-1 try-job: aarch64-msvc-1
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
|
I guess we can remove that test as we already have tidy checks for formatting in rust-analyzer |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
ca2cd06 to
f1944b6
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Run main rust-analyzer tests in rust-lang/rust CI try-job: aarch64-gnu try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: x86_64-msvc-1 try-job: aarch64-msvc-1
f1944b6 to
86bcd31
Compare
This comment has been minimized.
This comment has been minimized.
Pushed a change to exclude crates under @rustbot ready |
This comment was marked as resolved.
This comment was marked as resolved.
86bcd31 to
ebeb60a
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ebeb60a to
2710699
Compare
|
☔ The latest upstream changes (presumably #149499) made this pull request unmergeable. Please resolve the merge conflicts. |
Part of #147370.
MCP: rust-lang/compiler-team#923
This PR prepares
rust-analyzercrates within-rust-treecargo featues where needed, and and updates bootstrap to run the mainrust-analyzertests in rust-lang/rust CI, not just theproc-macro-srvcrate tests.This supersedes the earlier attempt at #136779. I was honestly expecting more failures in this PR, but looking back at the previous attempt, that makes sense because we no longer run
i686-mingw(32-bit windows-gnu) which had a bunch of these failures. In the earlier attempt I also disabled thei686-mingw-related failures fori686-msvcsince I didn't feel like digging into 32-bit msvc at the time. Try results from this PR shows that it's most likely limited to 32-bit windows-gnu specifically.rust-analyzertest remarksCARGO_WORKSPACE_DIRexpect-test-hack in order forexpect-testto be able to find the test expectation HTML files (forsyntax_highlightingtests inide). When I added the hack, ironically, it madeexpect-testunable to find the expectation files. I think this was because previously the path was of theproc-macro-srvcrate specifically, now we point to the root r-a workspace?cfg-related differences onaarch64-apple-darwinmight've been fixed? I can't tell, but we don't seem to be observing the differences now.config::{generate_config_documentation, generate_package_json_config}no longer fails. Perhaps they were fixed to no longer try to write to source directory?Review remarks
rustc_privatecompiler crates to use thein-rust-treecargo feature. I briefly tried to use a plain--cfg=in_rust_tree, but quickly realized it was very hacky, and needed invasive bootstrap changes. The cargo feature approach seems most "natural"/well-supported to both bootstrap and cargo.proc-macro-srvtests, but the whole r-a tests.try-job: aarch64-gnu
try-job: aarch64-apple
try-job: x86_64-mingw-1
try-job: i686-msvc-1
try-job: x86_64-msvc-1
try-job: aarch64-msvc-1