Skip to content

Replace LLVMRustContextCreate with normal LLVM-C API calls #147549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace LLVMRustContextCreate with normal LLVM-C API calls #147549

wants to merge 1 commit into from
+10 −12

Conversation

AMS21
Copy link
Contributor

@AMS21 AMS21 commented Oct 10, 2025

Since LLVMRustContextCreate can easily be replaced with a call to LLVMContextCreate and LLVMContextSetDiscardValueNames.

Work towards #46437

@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Zalathar
Zalathar reviewed Oct 10, 2025
View reviewed changes
nnethercote
nnethercote reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

@nnethercote nnethercote left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert on this, but is this actually an improvement? LLVMRustContextCreate isn't mentioned in #46437. And #46437 is now almost eight years old, and very little progress has apparently been made on it, which maybe suggests that it's not so important?

if a PR was filed that converted a whole bunch of the functions mentioned in #46437, that might be more compelling. But changing a single function like this... is it really worthwhile?

View changes since this review

Zalathar
Zalathar reviewed Oct 10, 2025
View reviewed changes
Zalathar
Zalathar reviewed Oct 10, 2025
View reviewed changes
compiler/rustc_codegen_llvm/src/llvm/ffi.rs

unsafe extern "C" {
// Create and destroy contexts.
pub(crate) fn LLVMContextCreate() -> &'static mut Context;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: Seeing &'static mut is always terrifying, but since the existing LLVMRust binding already does the same thing, I guess this isn't making things any worse.

I've been planning some changes of my own to replace these with raw pointers, but I can just as easily do that after merging this PR, so this is fine.

@Zalathar
Copy link
Contributor

I'm no expert on this, but is this actually an improvement? LLVMRustContextCreate isn't mentioned in #46437. And #46437 is now almost eight years old, and very little progress has apparently been made on it, which maybe suggests that it's not so important?

if a PR was filed that converted a whole bunch of the functions mentioned in #46437, that might be more compelling. But changing a single function like this... is it really worthwhile?

IMO there is a modest benefit in making this change, since removing LLVMRust bindings makes it easier to audit the ones that remain.

And in fact I was already planning a similar change of my own, so I'm willing to vouch for this being worthwhile.

@Zalathar
Copy link
Contributor

r? Zalathar

@rustbot rustbot assigned Zalathar and unassigned nnethercote Oct 10, 2025
@AMS21
Replace LLVMRustContextCreate with normal LLVM-C API calls
0abecda 
Since `LLVMRustContextCreate` can easily be replaced with a call to
`LLVMContextCreate` and `LLVMContextSetDiscardValueNames`.
@AMS21 AMS21 force-pushed the remove_llvm_rust_context_create branch from 5f8c98b to 0abecda Compare October 10, 2025 13:46
@Zalathar
Copy link
Contributor

Thanks.

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 11, 2025

📌 Commit 0abecda has been approved by Zalathar

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 11, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 12, 2025
@Zalathar
Rollup merge of rust-lang#147549 - AMS21:remove_llvm_rust_context_cre…
ba431a9 
…ate, r=Zalathar

Replace `LLVMRustContextCreate` with normal LLVM-C API calls

Since `LLVMRustContextCreate` can easily be replaced with a call to `LLVMContextCreate` and `LLVMContextSetDiscardValueNames`.

Work towards rust-lang#46437
@Zalathar Zalathar mentioned this pull request Oct 12, 2025
Closed
bors added a commit that referenced this pull request Oct 12, 2025
@bors
Auto merge of #147598 - Zalathar:rollup-87wjjvk, r=Zalathar
a6d9321 
Rollup of 12 pull requests

Successful merges:

 - #138799 (core: simplify `Extend` for tuples)
 - #146692 (Save x.py's help text for saving output time)
 - #147168 (Don't unconditionally build alloc for `no-std` targets)
 - #147178 ([DebugInfo] Improve formatting of MSVC enum struct variants)
 - #147240 (Add an ACP list item to the library tracking issue template)
 - #147246 (Explain not existed key in BTreeMap::split_off)
 - #147393 (Extract most code from `define_feedable!`)
 - #147495 (Update wasm-component-ld to 0.5.18)
 - #147503 (Fix documentation of Instant::now on mac)
 - #147541 (Change int-to-ptr transmute lowering back to inttoptr)
 - #147549 (Replace `LLVMRustContextCreate` with normal LLVM-C API calls)
 - #147596 (Adjust the Arm targets in CI to reflect latest changes)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 12, 2025
@matthiaskrgr
Rollup merge of rust-lang#147549 - AMS21:remove_llvm_rust_context_cre…
64b37b9 
…ate, r=Zalathar

Replace `LLVMRustContextCreate` with normal LLVM-C API calls

Since `LLVMRustContextCreate` can easily be replaced with a call to `LLVMContextCreate` and `LLVMContextSetDiscardValueNames`.

Work towards rust-lang#46437
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 12, 2025
Open
bors added a commit that referenced this pull request Oct 12, 2025
@bors
Auto merge of #147603 - matthiaskrgr:rollup-j6uae13, r=matthiaskrgr
8927649 
Rollup of 8 pull requests

Successful merges:

 - #138799 (core: simplify `Extend` for tuples)
 - #145897 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#4 of Batch #2])
 - #146692 (Save x.py's help text for saving output time)
 - #147240 (Add an ACP list item to the library tracking issue template)
 - #147246 (Explain not existed key in BTreeMap::split_off)
 - #147393 (Extract most code from `define_feedable!`)
 - #147503 (Fix documentation of Instant::now on mac)
 - #147549 (Replace `LLVMRustContextCreate` with normal LLVM-C API calls)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nnethercote nnethercote nnethercote left review comments

@Zalathar Zalathar Zalathar left review comments

Assignees

@Zalathar Zalathar

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AMS21 @rustbot @Zalathar @bors @nnethercote