Return spans out of is_doc_comment to reduce reliance on .span() on attributes
#147676
+22
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rustbot
added
A-attributes
jdonszelmann
commented
Oct 14, 2025
| if let Some((doc_str, comment_kind)) = attr.doc_str_and_comment_kind() { | ||
| let doc = beautify_doc_string(doc_str, comment_kind); | ||
| let (span, kind, from_expansion) = if attr.is_doc_comment() { | ||
| let span = attr.span(); |
There was a problem hiding this comment.
This change specifically addresses this span call here on AttributeExt which is quite annoying otherwise. We want to start merging doc comments in the future, just like other attributes. Before, we needed an exception in the .span() function just for doc comments.
GuillaumeGomez
approved these changes
Oct 15, 2025
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 15, 2025
Rollup of 11 pull requests Successful merges: - #143191 (Stabilize `rwlock_downgrade` library feature) - #147444 (Allow printing a fully-qualified path in `def_path_str`) - #147527 (Update t-compiler beta nomination Zulip msg) - #147670 (some `ErrorGuaranteed` cleanups) - #147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes) - #147708 (const `mem::drop`) - #147710 (Fix ICE when using contracts on async functions) - #147716 (Fix some comments) - #147718 (miri: use allocator_shim_contents codegen helper) - #147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius) - #147742 (Revert unintentional whitespace changes to rustfmt-excluded file) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 16, 2025
Rollup merge of #147676 - jdonszelmann:span-is-doc-comment, r=GuillaumeGomez Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes r? `@GuillaumeGomez`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Oct 16, 2025
Rollup of 11 pull requests Successful merges: - rust-lang/rust#143191 (Stabilize `rwlock_downgrade` library feature) - rust-lang/rust#147444 (Allow printing a fully-qualified path in `def_path_str`) - rust-lang/rust#147527 (Update t-compiler beta nomination Zulip msg) - rust-lang/rust#147670 (some `ErrorGuaranteed` cleanups) - rust-lang/rust#147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes) - rust-lang/rust#147708 (const `mem::drop`) - rust-lang/rust#147710 (Fix ICE when using contracts on async functions) - rust-lang/rust#147716 (Fix some comments) - rust-lang/rust#147718 (miri: use allocator_shim_contents codegen helper) - rust-lang/rust#147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius) - rust-lang/rust#147742 (Revert unintentional whitespace changes to rustfmt-excluded file) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @GuillaumeGomez