tests: activate misspelled `gdb-check` in `function-arg-initialization.rs` #147728

Enselic · 2025-10-15T15:00:24Z

In 9253e12 a bunch of gdbr-check (for rust-gdb) directives and gdbg-check (for plain gdb) directives were added. But in two places the author accidentally wrote gdbt-check instead (t is next to r on the keyboard). This commit fixes that typo.

#129218 later renamed gdbr-check to just gdb-check which is why we rename to gdb-check directly.

The test still passes locally for me after the change, but fails if I change the gdb-check checks to check for some other string, so the check seems to still perform its intended function.

Note that we need to add a std::hint::black_box() to avoid

$4 = <optimized out>

prints on at least aarch64-gnu-llvm-20-1.

After this there are no more instances of the string gdbt in the code base:

$ git grep gdbt

try-job: dist-i586-gnu-i586-i686-musl

rustbot · 2025-10-15T15:00:29Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tests/debuginfo/function-arg-initialization.rs

Zalathar · 2025-10-26T03:29:34Z

Looks good; might as well just try to merge this and #148097.

@bors r+ rollup

bors · 2025-10-26T03:29:37Z

📌 Commit b2af5c5 has been approved by Zalathar

It is now in the queue for this repository.

tests: activate misspelled `gdb-check` in `function-arg-initialization.rs` In 9253e12 a bunch of `gdbr-check` (for `rust-gdb`) directives and `gdbg-check` (for plain `gdb`) directives were added. But in two places the author accidentally wrote `gdbt-check` instead (`t` is next to `r` on the keyboard). This commit fixes that typo. rust-lang#129218 later renamed `gdbr-check` to just `gdb-check` which is why we rename to `gdb-check` directly. The test still passes locally for me after the change, but fails if I change the `gdb-check` checks to check for some other string, so the check seems to still perform its intended function. Note that we need to add a `std::hint::black_box()` to avoid $4 = <optimized out> prints on at least `aarch64-gnu-llvm-20-1`. After this there are no more instances of the string `gdbt` in the code base: ```console $ git grep gdbt ```

…lathar tests/debuginfo/closures.rs: Activate misspelled `cdb-check` Split out from rust-lang#147799 because these seemingly simple corrections can turn out to be non-trivial. See rust-lang#147728 for example.

Rollup of 4 pull requests Successful merges: - #145665 (Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`) - #147728 (tests: activate misspelled `gdb-check` in `function-arg-initialization.rs`) - #148097 (tests/debuginfo/closures.rs: Activate misspelled `cdb-check`) - #148118 (Improve the ICE message for invalid nullary intrinsic calls) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2025-10-26T06:42:30Z

Failed in rollup in dist-i586-gnu-i586-i686-musl: #148123 (comment)

@bors r-

Enselic · 2025-11-01T07:56:53Z

@rustbot ready

jieyouxu · 2025-11-01T16:37:46Z

r? Zalathar (since you already looked at this)

Zalathar · 2025-11-02T00:56:42Z

@bors r+ rollup=iffy

bors · 2025-11-02T00:56:44Z

📌 Commit 192f862 has been approved by Zalathar

It is now in the queue for this repository.

tests: activate misspelled `gdb-check` in `function-arg-initialization.rs` In 9253e12 a bunch of `gdbr-check` (for `rust-gdb`) directives and `gdbg-check` (for plain `gdb`) directives were added. But in two places the author accidentally wrote `gdbt-check` instead (`t` is next to `r` on the keyboard). This commit fixes that typo. #129218 later renamed `gdbr-check` to just `gdb-check` which is why we rename to `gdb-check` directly. The test still passes locally for me after the change, but fails if I change the `gdb-check` checks to check for some other string, so the check seems to still perform its intended function. Note that we need to add a `std::hint::black_box()` to avoid $4 = <optimized out> prints on at least `aarch64-gnu-llvm-20-1`. After this there are no more instances of the string `gdbt` in the code base: ```console $ git grep gdbt ``` try-job: dist-i586-gnu-i586-i686-musl

bors · 2025-11-02T04:43:13Z

⌛ Testing commit 192f862 with merge a56143f...

bors · 2025-11-02T06:50:39Z

💔 Test failed - checks-actions

Enselic · 2025-11-03T04:07:14Z

GitHub gives me errors when trying to look at the test log, so I'll re-run the failed job manually:

@bors try jobs=x86_64-gnu

tests: activate misspelled `gdb-check` in `function-arg-initialization.rs` try-job: x86_64-gnu

rust-bors · 2025-11-03T06:25:16Z

☀️ Try build successful (CI)
Build commit: fce8500 (fce85000520569138267188d347c6864883692c4, parent: c5dabe8cf798123087d094f06417f5a767ca73e8)

Enselic · 2025-11-03T06:48:42Z

Previous failure seems like flakiness.

@bors retry

Zalathar · 2025-11-03T06:51:15Z

My rule of thumb is that if GitHub refuses to show a raw log, then it's probably the case that a GitHub runner flaked out.

bors · 2025-11-03T10:10:38Z

⌛ Testing commit 192f862 with merge 35ebdf9...

bors · 2025-11-03T13:22:47Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 35ebdf9 to master...

github-actions · 2025-11-03T13:26:20Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f2bae99 (parent) -> 35ebdf9 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 35ebdf9ba1414456dfe1cb6a6b13ebae80e99734 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-various-2: 2060.4s -> 2294.8s (+11.4%)
x86_64-gnu-aux: 12107.6s -> 10859.2s (-10.3%)
x86_64-mingw-1: 9346.7s -> 10291.8s (+10.1%)
x86_64-gnu-stable: 6354.0s -> 6991.0s (+10.0%)
aarch64-apple: 7754.0s -> 8509.9s (+9.7%)
aarch64-msvc-2: 4863.6s -> 5307.6s (+9.1%)
dist-loongarch64-linux: 5514.9s -> 5014.4s (-9.1%)
dist-x86_64-apple: 8021.1s -> 7351.9s (-8.3%)
dist-aarch64-apple: 7820.8s -> 7218.1s (-7.7%)
dist-ohos-armv7: 4229.4s -> 3933.3s (-7.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-03T14:42:39Z

Finished benchmarking commit (35ebdf9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.169s -> 474.155s (-0.21%)
Artifact size: 390.81 MiB -> 390.84 MiB (0.01%)

rustbot assigned Mark-Simulacrum Oct 15, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 15, 2025

This comment has been minimized.

Sign in to view

Enselic force-pushed the gdbt-check-typo branch from ca052c1 to b8c1b25 Compare October 15, 2025 16:50

This comment has been minimized.

Sign in to view

Enselic force-pushed the gdbt-check-typo branch 3 times, most recently from 133bfad to f88ff0b Compare October 16, 2025 03:55

Enselic mentioned this pull request Oct 17, 2025

compiletest: Use //@ prefixes also for debuginfo test directives #147799

Open

1 task

Enselic commented Oct 17, 2025

View reviewed changes

tests/debuginfo/function-arg-initialization.rs Outdated Show resolved Hide resolved

Enselic added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2025

Enselic force-pushed the gdbt-check-typo branch 3 times, most recently from 9cfef2e to b2af5c5 Compare October 17, 2025 16:58

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 17, 2025

Enselic mentioned this pull request Oct 25, 2025

tests/debuginfo/closures.rs: Activate misspelled cdb-check #148097

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2025

Zalathar mentioned this pull request Oct 26, 2025

Rollup of 4 pull requests #148123

Closed

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 26, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 1, 2025

rustbot assigned Zalathar and unassigned Mark-Simulacrum Nov 1, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 2, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Nov 3, 2025

Auto merge of #147728 - Enselic:gdbt-check-typo, r=<try>

fce8500

tests: activate misspelled `gdb-check` in `function-arg-initialization.rs` try-job: x86_64-gnu

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 3, 2025

bors merged commit 35ebdf9 into rust-lang:master Nov 3, 2025
13 checks passed

rustbot added this to the 1.93.0 milestone Nov 3, 2025

tests: activate misspelled gdb-check in function-arg-initialization.rs #147728

tests: activate misspelled gdb-check in function-arg-initialization.rs #147728

Conversation

Enselic commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 15, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Zalathar commented Oct 26, 2025

Uh oh!

bors commented Oct 26, 2025

Uh oh!

Zalathar commented Oct 26, 2025

Uh oh!

Enselic commented Nov 1, 2025

Uh oh!

jieyouxu commented Nov 1, 2025

Uh oh!

Zalathar commented Nov 2, 2025

Uh oh!

bors commented Nov 2, 2025

Uh oh!

bors commented Nov 2, 2025

Uh oh!

bors commented Nov 2, 2025

Uh oh!

Enselic commented Nov 3, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Nov 3, 2025

Uh oh!

Enselic commented Nov 3, 2025

Uh oh!

Zalathar commented Nov 3, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

bors commented Nov 3, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 3, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Nov 3, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

tests: activate misspelled `gdb-check` in `function-arg-initialization.rs` #147728

tests: activate misspelled `gdb-check` in `function-arg-initialization.rs` #147728

Enselic commented Oct 15, 2025 •

edited

Loading