Skip to content

Conversation

@Jamesbarford
Copy link
Contributor

  • Add a command for adding a collector to the database
  • Add a command called DequeueJob (open to alternative names) that will take a job from the job_queue and print to standard out if a job exists.
  • Exposed a few properties on the structs BenchmarkJob and CollectorConfig using pub fn <name_of_property>() methods
  • More mapping functions between the collector / database enums
  • Altered the job_queue table from having a collector_id to collector_name as the name column in the collector is unique, cannot be NULL and saves a lookup to get the id using the collector_name. I've retained the foreign key constraint.

@Jamesbarford Jamesbarford force-pushed the feat/collector-dequeue-job branch from fb9d060 to 425c9cd Compare July 29, 2025 14:56
@Jamesbarford Jamesbarford force-pushed the feat/collector-dequeue-job branch from 425c9cd to 296f585 Compare July 30, 2025 07:26
@Jamesbarford Jamesbarford force-pushed the feat/collector-dequeue-job branch from 123b916 to a094fa3 Compare July 30, 2025 13:33
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will continue on top of this and try to join the dequeuing logic with actually running the benchmarks.

@Kobzol Kobzol merged commit 43d74a7 into rust-lang:master Jul 31, 2025
11 checks passed
@Jamesbarford Jamesbarford deleted the feat/collector-dequeue-job branch July 31, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants