- 
                Notifications
    
You must be signed in to change notification settings  - Fork 161
 
Feat; collector dequeue job #2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            Kobzol
  merged 7 commits into
  rust-lang:master
from
Jamesbarford:feat/collector-dequeue-job
  
      
      
   
  Jul 31, 2025 
      
    
                
     Merged
            
            Feat; collector dequeue job #2212
                    Kobzol
  merged 7 commits into
  rust-lang:master
from
Jamesbarford:feat/collector-dequeue-job
  
      
      
   
  Jul 31, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    fb9d060    to
    425c9cd      
    Compare
  
    425c9cd    to
    296f585      
    Compare
  
    
              
                    Kobzol
  
              
              reviewed
              
                  
                    Jul 30, 2025 
                  
              
              
            
            
…hmark_request status, use string constants rather than the enum for setting the status strings
…d helpers on `target`
123b916    to
    a094fa3      
    Compare
  
    
              
                    Kobzol
  
              
              reviewed
              
                  
                    Jul 31, 2025 
                  
              
              
            
            
              
                    Kobzol
  
              
              approved these changes
              
                  
                    Jul 31, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I will continue on top of this and try to join the dequeuing logic with actually running the benchmarks.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
DequeueJob(open to alternative names) that will take a job from thejob_queueand print to standard out if a job exists.BenchmarkJobandCollectorConfigusingpub fn <name_of_property>()methodsjob_queuetable from having acollector_idtocollector_nameas the name column in the collector is unique, cannot be NULL and saves a lookup to get theidusing thecollector_name. I've retained the foreign key constraint.